Merge branch 'master' into bc/remove-null-check

Author: Brian Chen

.changeset/clean-toes-pump.md

@@ -0,0 +1,25 @@
+---
+"@firebase/app": patch
+"@firebase/auth": patch
+"@firebase/component": patch
+"@firebase/database": patch
+"firebase": major
+"@firebase/firestore": patch
+"@firebase/functions": patch
+"@firebase/performance": patch
+"@firebase/remote-config": patch
+"rxfire": patch
+"@firebase/util": patch
+---
+
+Point browser field to esm build. Now you need to use default import instead of namespace import to import firebase.
+
+Before this change
+```
+import * as firebase from 'firebase/app';
+```
+
+After this change
+```
+import firebase from 'firebase/app';
+```

.changeset/early-elephants-learn.md

@@ -0,0 +1,6 @@
+---
+"firebase": major
+"@firebase/firestore": major
+---
+
+This releases removes all input validation. Please use our TypeScript types to validate API usage. 

.changeset/funny-ties-ring.md

@@ -0,0 +1,5 @@
+---
+"@firebase/util": patch
+---
+
+Write template data to a new `customData` field in` FirebaseError` instead of writing to the error object itself to avoid overwriting existing fields.

.changeset/long-hornets-scream.md

@@ -74,13 +74,30 @@ module.exports = {
             ]
           }
         }
+      },
+      {
+        test: /\.js$/,
+        include: function (modulePath) {
+          const match = /node_modules\/@firebase.*/.test(modulePath);
+          if (match) {
+            console.log('modulePath', modulePath, match);
+          }
+          return match;
+        },
+        use: {
+          loader: 'babel-loader',
+          options: {
+            plugins: ['@babel/plugin-transform-modules-commonjs']
+          }
+        }
       }
     ]
   },
   resolve: {
     modules: ['node_modules', path.resolve(__dirname, '../../node_modules')],
-    mainFields: ['browser', 'main', 'module'],
-    extensions: ['.js', '.ts']
+    mainFields: ['browser', 'module', 'main'],
+    extensions: ['.js', '.ts'],
+    symlinks: false
   },
   plugins: [
     new webpack.NormalModuleReplacementPlugin(

.changeset/ninety-kings-agree.md

@@ -7,9 +7,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js -s test"
   },
   "devDependencies": {
-    "firebase": "7.23.0",
-    "@babel/core": "7.11.6",
-    "@babel/preset-env": "7.11.5",
+    "firebase": "7.24.0",
     "@types/chai": "4.2.13",
     "@types/mocha": "7.0.2",
     "chai": "4.2.0",

.changeset/silent-brooms-search.md

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import * as firebase from 'firebase';
+import firebase from 'firebase';
 import * as namespaceDefinition from './namespaceDefinition.json';
 import validateNamespace from './validator';
 

.changeset/silver-dolls-wave.md

@@ -15,7 +15,7 @@
   },
   "devDependencies": {
     "@firebase/app": "0.6.11",
-    "@firebase/firestore": "1.17.3",
+    "@firebase/firestore": "1.18.0",
     "@types/mocha": "7.0.2",
     "gulp": "4.0.2",
     "gulp-filter": "6.0.0",

.changeset/stupid-dots-grab.md

@@ -9,7 +9,7 @@
     "test:manual": "mocha --exit"
   },
   "devDependencies": {
-    "firebase": "7.23.0",
+    "firebase": "7.24.0",
     "chai": "4.2.0",
     "chromedriver": "86.0.0",
     "express": "4.17.1",

.changeset/yellow-turkeys-lay.md

@@ -1,5 +1,4 @@
 {
-  "lerna": "3.10.5",
   "version": "independent",
   "npmClient": "yarn",
   "packages": [

config/webpack.test.js

@@ -52,7 +52,7 @@
     "api-report": "lerna run --scope @firebase/*-exp api-report",
     "docgen:exp": "ts-node-script scripts/exp/docgen.ts",
     "postinstall": "yarn --cwd repo-scripts/changelog-generator build",
-    "sa": "ts-node-script repo-scripts/size-analysis/analysis.ts"
+    "sa": "ts-node-script repo-scripts/size-analysis/cli.ts"
   },
   "repository": {
     "type": "git",
@@ -67,8 +67,8 @@
   "devDependencies": {
     "@changesets/changelog-github": "0.2.7",
     "@changesets/cli": "2.11.0",
-    "@microsoft/api-documenter": "7.9.10",
-    "@microsoft/api-extractor": "7.10.4",
+    "api-documenter-me": "0.1.0",
+    "api-extractor-me": "0.1.0",
     "@types/chai": "4.2.13",
     "@types/chai-as-promised": "7.1.3",
     "@types/child-process-promise": "2.2.1",
@@ -87,6 +87,9 @@
     "@typescript-eslint/eslint-plugin-tslint": "4.4.1",
     "@typescript-eslint/parser": "4.4.1",
     "babel-loader": "8.1.0",
+    "@babel/core": "7.11.6",
+    "@babel/preset-env": "7.11.5",
+    "@babel/plugin-transform-modules-commonjs": "7.12.1",
     "chai": "4.2.0",
     "chai-as-promised": "7.1.1",
     "chalk": "4.1.0",

integration/firebase/package.json

@@ -284,7 +284,7 @@ describe('api/_performApiRequest', () => {
         assert.fail('Call should have failed');
       } catch (e) {
         expect(e.code).to.eq(`auth/${AuthErrorCode.NEED_CONFIRMATION}`);
-        expect(e._tokenResponse).to.eql({
+        expect((e as FirebaseError).customData!._tokenResponse).to.eql({
           needConfirmation: true,
           idToken: 'id-token'
         });
@@ -314,7 +314,9 @@ describe('api/_performApiRequest', () => {
         assert.fail('Call should have failed');
       } catch (e) {
         expect(e.code).to.eq(`auth/${AuthErrorCode.CREDENTIAL_ALREADY_IN_USE}`);
-        expect(e._tokenResponse).to.eql(response);
+        expect((e as FirebaseError).customData!._tokenResponse).to.eql(
+          response
+        );
       }
     });
 
@@ -343,8 +345,10 @@ describe('api/_performApiRequest', () => {
         assert.fail('Call should have failed');
       } catch (e) {
         expect(e.code).to.eq(`auth/${AuthErrorCode.EMAIL_EXISTS}`);
-        expect(e.email).to.eq('[email protected]');
-        expect(e.phoneNumber).to.eq('+1555-this-is-a-number');
+        expect((e as FirebaseError).customData!.email).to.eq('[email protected]');
+        expect((e as FirebaseError).customData!.phoneNumber).to.eq(
+          '+1555-this-is-a-number'
+        );
       }
     });
   });

integration/firebase/test/namespace.test.ts

@@ -251,6 +251,8 @@ function makeTaggedError(
   }
 
   const error = AUTH_ERROR_FACTORY.create(code, errorParams);
-  (error as TaggedWithTokenResponse)._tokenResponse = response;
+
+  // We know customData is defined on error because errorParams is defined
+  (error.customData! as TaggedWithTokenResponse)._tokenResponse = response;
   return error;
 }

integration/firestore/package.json

@@ -76,9 +76,9 @@ function parseDeepLink(url: string): string {
   return iOSDoubleDeepLink || iOSDeepLink || doubleDeepLink || link || url;
 }
 
-/** 
- * {@inheritDoc @firebase/auth-types-exp#ActionCodeURL} 
- * 
+/**
+ * {@inheritDoc @firebase/auth-types-exp#ActionCodeURL}
+ *
  * @public
  */
 export class ActionCodeURL implements externs.ActionCodeURL {
@@ -129,9 +129,9 @@ export class ActionCodeURL implements externs.ActionCodeURL {
   }
 }
 
-/** 
- * {@inheritDoc @firebase/auth-types-exp#ActionCodeURL.parseLink} 
- * 
+/**
+ * {@inheritDoc @firebase/auth-types-exp#ActionCodeURL.parseLink}
+ *
  * @public
  */
 export function parseActionCodeURL(link: string): externs.ActionCodeURL | null {

integration/messaging/package.json

@@ -59,7 +59,7 @@ describe('src/core/providers/facebook', () => {
     const error = AUTH_ERROR_FACTORY.create(AuthErrorCode.NEED_CONFIRMATION, {
       appName: 'foo'
     });
-    (error as TaggedWithTokenResponse)._tokenResponse = {
+    (error.customData! as TaggedWithTokenResponse)._tokenResponse = {
       ...TEST_ID_TOKEN_RESPONSE,
       oauthAccessToken: 'access-token'
     };

lerna.json

@@ -48,7 +48,7 @@ export class FacebookAuthProvider extends OAuthProvider {
     error: FirebaseError
   ): externs.OAuthCredential | null {
     return FacebookAuthProvider.credentialFromTaggedObject(
-      error as TaggedWithTokenResponse
+      (error.customData || {}) as TaggedWithTokenResponse
     );
   }
 

package.json

@@ -59,7 +59,7 @@ describe('src/core/providers/github', () => {
     const error = AUTH_ERROR_FACTORY.create(AuthErrorCode.NEED_CONFIRMATION, {
       appName: 'foo'
     });
-    (error as TaggedWithTokenResponse)._tokenResponse = {
+    (error.customData! as TaggedWithTokenResponse)._tokenResponse = {
       ...TEST_ID_TOKEN_RESPONSE,
       oauthAccessToken: 'access-token'
     };

packages-exp/auth-exp/src/api/index.test.ts

@@ -48,7 +48,7 @@ export class GithubAuthProvider extends OAuthProvider {
     error: FirebaseError
   ): externs.OAuthCredential | null {
     return GithubAuthProvider.credentialFromTaggedObject(
-      error as TaggedWithTokenResponse
+      (error.customData || {}) as TaggedWithTokenResponse
     );
   }
 

packages-exp/auth-exp/src/api/index.ts

@@ -62,7 +62,7 @@ describe('src/core/providers/google', () => {
     const error = AUTH_ERROR_FACTORY.create(AuthErrorCode.NEED_CONFIRMATION, {
       appName: 'foo'
     });
-    (error as TaggedWithTokenResponse)._tokenResponse = {
+    (error.customData! as TaggedWithTokenResponse)._tokenResponse = {
       ...TEST_ID_TOKEN_RESPONSE,
       oauthAccessToken: 'access-token',
       oauthIdToken: 'id-token'

packages-exp/auth-exp/src/core/action_code_url.ts

@@ -53,7 +53,7 @@ export class GoogleAuthProvider extends OAuthProvider {
     error: FirebaseError
   ): externs.OAuthCredential | null {
     return GoogleAuthProvider.credentialFromTaggedObject(
-      error as TaggedWithTokenResponse
+      (error.customData || {}) as TaggedWithTokenResponse
     );
   }
 

packages-exp/auth-exp/src/core/providers/facebook.test.ts

@@ -79,7 +79,7 @@ describe('src/core/providers/twitter', () => {
     const error = AUTH_ERROR_FACTORY.create(AuthErrorCode.NEED_CONFIRMATION, {
       appName: 'foo'
     });
-    (error as TaggedWithTokenResponse)._tokenResponse = {
+    (error.customData! as TaggedWithTokenResponse)._tokenResponse = {
       ...TEST_ID_TOKEN_RESPONSE,
       oauthAccessToken: 'access-token',
       oauthTokenSecret: 'token-secret'

packages-exp/auth-exp/src/core/providers/facebook.ts

@@ -67,7 +67,7 @@ export class TwitterAuthProvider extends OAuthProvider {
     error: FirebaseError
   ): externs.OAuthCredential | null {
     return TwitterAuthProvider.credentialFromTaggedObject(
-      error as TaggedWithTokenResponse
+      (error.customData || {}) as TaggedWithTokenResponse
     );
   }