Allow Collection.add() to use custom objects (#2607)

Author: Brian Chen

packages/firestore/CHANGELOG.md

@@ -1,4 +1,8 @@
 # Unreleased
+- [fixed] Fixed an issue where `CollectionReference.add()` would reject
+  custom types when using `withConverter()`. (#2606)
+
+# 1.9.3
 - [fixed] Fixed an issue where auth credentials were not respected in some
   Firefox or Chrome extensions. (#1491)
 - [changed] Firestore previously required that every document read in a

packages/firestore/src/api/database.ts

@@ -2461,7 +2461,10 @@ export class CollectionReference<T = firestore.DocumentData> extends Query<T>
 
   add(value: T): Promise<firestore.DocumentReference<T>> {
     validateExactNumberOfArgs('CollectionReference.add', arguments, 1);
-    validateArgType('CollectionReference.add', 'object', 1, value);
+    const convertedValue = this._converter
+      ? this._converter.toFirestore(value)
+      : value;
+    validateArgType('CollectionReference.add', 'object', 1, convertedValue);
     const docRef = this.doc();
     return docRef.set(value).then(() => docRef);
   }

packages/firestore/test/integration/api/database.test.ts

@@ -1214,12 +1214,9 @@ apiDescribe('Database', (persistence: boolean) => {
 
     it('for CollectionReference.withConverter()', () => {
       return withTestDb(persistence, async db => {
-        const docRef = db
-          .collection('posts')
-          .withConverter(postConverter)
-          .doc();
+        const coll = db.collection('posts').withConverter(postConverter);
 
-        await docRef.set(new Post('post', 'author'));
+        const docRef = await coll.add(new Post('post', 'author'));
         const postData = await docRef.get();
         const post = postData.data();
         expect(post).to.not.equal(undefined);