Skip to content

Commit d4ab17f

Browse files
committed
Remove bundles from public interfaces.
1 parent 80dc41d commit d4ab17f

File tree

9 files changed

+251
-336
lines changed

9 files changed

+251
-336
lines changed

integration/firestore/firebase_export.ts

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -55,16 +55,5 @@ const Timestamp = firebase.firestore.Timestamp;
5555
const GeoPoint = firebase.firestore.GeoPoint;
5656
const FieldValue = firebase.firestore.FieldValue;
5757
const Blob = firebase.firestore.Blob;
58-
const loadBundle = firebase.firestore.loadBundle;
59-
const namedQuery = firebase.firestore.namedQuery;
6058

61-
export {
62-
Firestore,
63-
FieldValue,
64-
FieldPath,
65-
Timestamp,
66-
Blob,
67-
GeoPoint,
68-
loadBundle,
69-
namedQuery
70-
};
59+
export { Firestore, FieldValue, FieldPath, Timestamp, Blob, GeoPoint };

integration/firestore/firebase_export_memory.ts

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -55,16 +55,5 @@ const Timestamp = firebase.firestore.Timestamp;
5555
const GeoPoint = firebase.firestore.GeoPoint;
5656
const FieldValue = firebase.firestore.FieldValue;
5757
const Blob = firebase.firestore.Blob;
58-
const loadBundle = firebase.firestore.loadBundle;
59-
const namedQuery = firebase.firestore.namedQuery;
6058

61-
export {
62-
Firestore,
63-
FieldValue,
64-
FieldPath,
65-
Timestamp,
66-
Blob,
67-
GeoPoint,
68-
loadBundle,
69-
namedQuery
70-
};
59+
export { Firestore, FieldValue, FieldPath, Timestamp, Blob, GeoPoint };

packages/firestore-types/index.d.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -99,16 +99,6 @@ export class FirebaseFirestore {
9999
INTERNAL: { delete: () => Promise<void> };
100100
}
101101

102-
export function loadBundle(
103-
db: FirebaseFirestore,
104-
bundleData: ArrayBuffer | ReadableStream<ArrayBuffer> | string
105-
): LoadBundleTask;
106-
107-
export function namedQuery(
108-
db: FirebaseFirestore,
109-
name: string
110-
): Promise<Query<DocumentData> | null>;
111-
112102
export interface LoadBundleTask {
113103
onProgress(
114104
next?: (progress: LoadBundleTaskProgress) => any,

packages/firestore/exp/test/shim.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,9 @@ import {
5555
validateSetOptions
5656
} from '../../src/util/input_validation';
5757
import { Compat } from '../../src/compat/compat';
58-
import { Firestore, loadBundle, namedQuery } from '../../src/api/database';
58+
import { Firestore } from '../../src/api/database';
5959

6060
export { GeoPoint, Timestamp } from '../index';
61-
export { loadBundle, namedQuery };
6261

6362
/* eslint-disable @typescript-eslint/no-explicit-any */
6463

packages/firestore/register-module.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@ declare module '@firebase/app-types' {
3636
Transaction: typeof types.Transaction;
3737
WriteBatch: typeof types.WriteBatch;
3838
setLogLevel: typeof types.setLogLevel;
39-
loadBundle: typeof types.loadBundle;
40-
namedQuery: typeof types.namedQuery;
4139
};
4240
}
4341
interface FirebaseApp {

packages/firestore/src/api/database.ts

Lines changed: 1 addition & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,7 @@ import {
3030
firestoreClientGetDocumentViaSnapshotListener,
3131
firestoreClientListen,
3232
firestoreClientTransaction,
33-
firestoreClientWrite,
34-
firestoreClientLoadBundle,
35-
firestoreClientGetNamedQuery
33+
firestoreClientWrite
3634
} from '../core/firestore_client';
3735
import {
3836
Bound,
@@ -143,7 +141,6 @@ import {
143141
import { newUserDataReader } from '../../lite/src/api/reference';
144142
import { makeDatabaseInfo } from '../../lite/src/api/database';
145143
import { DEFAULT_HOST } from '../../lite/src/api/components';
146-
import { LoadBundleTask } from './bundle';
147144

148145
/**
149146
* Constant used to indicate the LRU garbage collection should be disabled.
@@ -427,36 +424,6 @@ export function setLogLevel(level: PublicLogLevel): void {
427424
setClientLogLevel(level);
428425
}
429426

430-
export function loadBundle(
431-
db: Firestore,
432-
bundleData: ArrayBuffer | ReadableStream<Uint8Array> | string
433-
): LoadBundleTask {
434-
const resultTask = new LoadBundleTask();
435-
// eslint-disable-next-line @typescript-eslint/no-floating-promises
436-
firestoreClientLoadBundle(
437-
ensureFirestoreConfigured(db._delegate),
438-
bundleData,
439-
resultTask
440-
);
441-
return resultTask;
442-
}
443-
444-
export function namedQuery(
445-
db: Firestore,
446-
name: string
447-
): Promise<PublicQuery | null> {
448-
return firestoreClientGetNamedQuery(
449-
ensureFirestoreConfigured(db._delegate),
450-
name
451-
).then(namedQuery => {
452-
if (!namedQuery) {
453-
return null;
454-
}
455-
456-
return new Query(namedQuery.query, db, null);
457-
});
458-
}
459-
460427
/**
461428
* A reference to a transaction.
462429
*/

packages/firestore/src/config.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ import {
3030
QuerySnapshot,
3131
Transaction,
3232
WriteBatch,
33-
loadBundle,
34-
namedQuery,
3533
setLogLevel
3634
} from './api/database';
3735
import { Blob } from './api/blob';
@@ -56,8 +54,6 @@ const firestoreNamespace = {
5654
FieldPath,
5755
FieldValue,
5856
setLogLevel,
59-
loadBundle,
60-
namedQuery,
6157
CACHE_SIZE_UNLIMITED
6258
};
6359

0 commit comments

Comments
 (0)