Address comments

Author: wu-hui

.changeset/lemon-steaks-draw.md

@@ -1,3 +1,5 @@
 ---
-
+"@firebase/firestore": feature
 ---
+
+Add support for loading Firestore Bundle Files.

packages/firestore/rollup.shared.js

@@ -130,7 +130,74 @@ const manglePrivatePropertiesOptions = {
   mangle: {
     properties: {
       regex: /^__PRIVATE_/,
-      reserved: ['do']
+      // All JS Keywords are reserved. Although this should be taken cared of by
+      // Terser, we have seen issues with `do`, hence the extra caution.
+      reserved: [
+        'abstract',
+        'arguments',
+        'await',
+        'boolean',
+        'break',
+        'byte',
+        'case',
+        'catch',
+        'char',
+        'class',
+        'const',
+        'continue',
+        'debugger',
+        'default',
+        'delete',
+        'do',
+        'double',
+        'else',
+        'enum',
+        'eval',
+        'export',
+        'extends',
+        'false',
+        'final',
+        'finally',
+        'float',
+        'for',
+        'function',
+        'goto',
+        'if',
+        'implements',
+        'import',
+        'in',
+        'instanceof',
+        'int',
+        'interface',
+        'let',
+        'long',
+        'native',
+        'new',
+        'null',
+        'package',
+        'private',
+        'protected',
+        'public',
+        'return',
+        'short',
+        'static',
+        'super',
+        'switch',
+        'synchronized',
+        'this',
+        'throw',
+        'throws',
+        'transient',
+        'true',
+        'try',
+        'typeof',
+        'var',
+        'void',
+        'volatile',
+        'while',
+        'with',
+        'yield'
+      ]
     }
   }
 };

packages/firestore/src/local/local_store.ts

@@ -1278,7 +1278,7 @@ export async function ignoreIfPrimaryLeaseLoss(
  * This ensures that the loaded documents do not get garbage collected
  * right away.
  */
-export function umbrellaTarget(bundleName: string): Target {
+function umbrellaTarget(bundleName: string): Target {
   // It is OK that the path used for the query is not valid, because this will
   // not be read and queried.
   return queryToTarget(

packages/firestore/src/local/shared_client_state_schema.ts

@@ -118,7 +118,7 @@ export function createWebStorageOnlineStateKey(persistenceKey: string): string {
 // The WebStorage prefix that plays as a event to indicate the remote documents
 // might have changed due to some secondary tabs loading a bundle.
 // format of the key is:
-//     firestore_remote_documents_changed_<persistenceKey>
+//     firestore_bundle_loaded_<persistenceKey>
 export const BUNDLE_LOADED_KEY_PREFIX = 'firestore_bundle_loaded';
 export function createBundleLoadedKey(persistenceKey: string): string {
   return `${BUNDLE_LOADED_KEY_PREFIX}_${persistenceKey}`;