Strip debug asserts from prod builds

Author: avolkovi

packages-exp/app-exp/package.json

@@ -51,7 +51,7 @@
   "bugs": {
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
-  "typings": "./dist/app-exp.d.ts",
+  "typings": "./dist/app-exp-public.d.ts",
   "nyc": {
     "extension": [
       ".ts"

packages-exp/auth-exp/package.json

@@ -35,6 +35,7 @@
   },
   "license": "Apache-2.0",
   "devDependencies": {
+    "@rollup/plugin-strip": "^1.3.2",
     "rollup": "1.32.1",
     "rollup-plugin-json": "4.0.0",
     "rollup-plugin-replace": "2.2.0",

packages-exp/auth-exp/rollup.config.js

@@ -15,6 +15,7 @@
  * limitations under the License.
  */
 
+import strip from '@rollup/plugin-strip';
 import typescriptPlugin from 'rollup-plugin-typescript2';
 import typescript from 'typescript';
 import pkg from './package.json';
@@ -23,10 +24,20 @@ const deps = Object.keys(
   Object.assign({}, pkg.peerDependencies, pkg.dependencies)
 );
 
+/**
+ * Common plugins for all builds
+ */
+const commonPlugins = [
+  strip({
+    functions: ['debugAssert.*']
+  })
+]
+
 /**
  * ES5 Builds
  */
 const es5BuildPlugins = [
+  ...commonPlugins, 
   typescriptPlugin({
     typescript
   })
@@ -57,6 +68,7 @@ const es5Builds = [
  * ES2017 Builds
  */
 const es2017BuildPlugins = [
+  ...commonPlugins,
   typescriptPlugin({
     typescript,
     tsconfigOverride: {

packages-exp/auth-exp/src/core/util/delay.ts

@@ -17,6 +17,7 @@
 
 import { isMobileCordova, isReactNative } from '@firebase/util';
 import { isOnline } from './navigator';
+import { debugAssert } from './assert';
 
 export const _OFFLINE_DELAY_MS = 5000;
 
@@ -34,9 +35,7 @@ export class Delay {
     private readonly longDelay: number
   ) {
     // Internal error when improperly initialized.
-    if (shortDelay > longDelay) {
-      throw new Error('Short delay should be less than long delay!');
-    }
+    debugAssert(shortDelay > longDelay, 'Short delay should be less than long delay!');
     this.isMobile = isMobileCordova() || isReactNative();
   }
 

yarn.lock

@@ -1862,14 +1862,23 @@
   resolved "https://registry.npmjs.org/@protobufjs/utf8/-/utf8-1.1.0.tgz#a777360b5b39a1a2e5106f8e858f2fd2d060c570"
   integrity sha1-p3c2C1s5oaLlEG+OhY8v0tBgxXA=
 
+"@rollup/plugin-strip@^1.3.2":
+  version "1.3.2"
+  resolved "https://registry.npmjs.org/@rollup/plugin-strip/-/plugin-strip-1.3.2.tgz#9f52e99add99b835a4a3c14e02385f3726514923"
+  integrity sha512-dByULCvYdklJRJ50XqmA/ntyvVuVnnxOrgZ6cIIMBLLzQrsm9Ui15VD+6I8a11w8Ob9R7ySwYjFck9YCMzseKA==
+  dependencies:
+    "@rollup/pluginutils" "^3.0.4"
+    estree-walker "^1.0.1"
+    magic-string "^0.25.5"
+
 "@rollup/pluginutils@^3.0.1":
   version "3.0.8"
   resolved "https://registry.npmjs.org/@rollup/pluginutils/-/pluginutils-3.0.8.tgz#4e94d128d94b90699e517ef045422960d18c8fde"
   integrity sha512-rYGeAc4sxcZ+kPG/Tw4/fwJODC3IXHYDH4qusdN/b6aLw5LPUbzpecYbEJh4sVQGPFJxd2dBU4kc1H3oy9/bnw==
   dependencies:
     estree-walker "^1.0.1"
 
-"@rollup/pluginutils@^3.0.8":
+"@rollup/pluginutils@^3.0.4", "@rollup/pluginutils@^3.0.8":
   version "3.0.9"
   resolved "https://registry.npmjs.org/@rollup/pluginutils/-/pluginutils-3.0.9.tgz#aa6adca2c45e5a1b950103a999e3cddfe49fd775"
   integrity sha512-TLZavlfPAZYI7v33wQh4mTP6zojne14yok3DNSLcjoG/Hirxfkonn6icP5rrNWRn8nZsirJBFFpijVOJzkUHDg==
@@ -9813,7 +9822,7 @@ [email protected]:
   dependencies:
     sourcemap-codec "^1.4.4"
 
-[email protected], magic-string@^0.25.2:
+[email protected], magic-string@^0.25.2, magic-string@^0.25.5:
   version "0.25.7"
   resolved "https://registry.npmjs.org/magic-string/-/magic-string-0.25.7.tgz#3f497d6fd34c669c6798dcb821f2ef31f5445051"
   integrity sha512-4CrMT5DOHTDk4HYDlzmwu4FVCcIYI8gauveasrdCu2IKIFOJ3f0v/8MDGJCDL9oD2ppz/Av1b0Nj345H9M+XIA==
@@ -12590,6 +12599,17 @@ [email protected]:
     rollup-pluginutils "2.8.1"
     tslib "1.10.0"
 
+[email protected]:
+  version "0.26.0"
+  resolved "https://registry.npmjs.org/rollup-plugin-typescript2/-/rollup-plugin-typescript2-0.26.0.tgz#cee2b44d51d9623686656d76dc30a73c4de91672"
+  integrity sha512-lUK7XZVG77tu8dmv1L/0LZFlavED/5Yo6e4iMMl6fdox/yKdj4IFRRPPJEXNdmEaT1nDQQeCi7b5IwKHffMNeg==
+  dependencies:
+    find-cache-dir "^3.2.0"
+    fs-extra "8.1.0"
+    resolve "1.15.1"
+    rollup-pluginutils "2.8.2"
+    tslib "1.10.0"
+
 [email protected]:
   version "0.27.0"
   resolved "https://registry.npmjs.org/rollup-plugin-typescript2/-/rollup-plugin-typescript2-0.27.0.tgz#95ff96f9e07d5000a9d2df4d76b548f9a1f83511"
@@ -12618,7 +12638,7 @@ [email protected]:
   dependencies:
     estree-walker "^0.6.1"
 
-rollup-pluginutils@^2.5.0, rollup-pluginutils@^2.6.0, rollup-pluginutils@^2.8.1, rollup-pluginutils@^2.8.2:
+rollup-pluginutils@2.8.2, rollup-pluginutils@^2.5.0, rollup-pluginutils@^2.6.0, rollup-pluginutils@^2.8.1, rollup-pluginutils@^2.8.2:
   version "2.8.2"
   resolved "https://registry.npmjs.org/rollup-pluginutils/-/rollup-pluginutils-2.8.2.tgz#72f2af0748b592364dbd3389e600e5a9444a351e"
   integrity sha512-EEp9NhnUkwY8aif6bxgovPHMoMoNr2FulJziTndpt5H9RdwC47GSGuII9XxpSdzVGM0GWrNPHV6ie1LTNJPaLQ==
@@ -15536,4 +15556,4 @@ zip-stream@^2.1.2:
   dependencies:
     archiver-utils "^2.1.0"
     compress-commons "^2.1.1"
-    readable-stream "^3.4.0"
+    readable-stream "^3.4.0"