More PR Feedback

Author: avolkovi

packages-exp/auth-exp/src/core/user/user_impl.ts

@@ -34,7 +34,6 @@ export interface UserParameters {
   photoURL?: string;
 }
 
-
 function assertStringOrUndefined(
   assertion: unknown,
   appName: string
@@ -115,7 +114,7 @@ export class UserImpl implements User {
       photoURL
     } = object;
 
-    assert(uid && !!plainObjectTokenManager, auth.name);
+    assert(uid && plainObjectTokenManager, auth.name);
 
     const stsTokenManager = StsTokenManager.fromPlainObject(
       auth.name,

packages-exp/auth-exp/src/core/util/assert.ts

@@ -34,7 +34,11 @@ export function fail(appName: string, errorCode: AuthErrorCode): never {
  * @param assertion
  * @param appName
  */
-export function assert(assertion: unknown, appName: string, errorCode: AuthErrorCode = AuthErrorCode.INTERNAL_ERROR): asserts assertion {
+export function assert(
+  assertion: unknown,
+  appName: string,
+  errorCode: AuthErrorCode = AuthErrorCode.INTERNAL_ERROR
+): asserts assertion {
   if (!assertion) {
     fail(appName, errorCode);
   }
@@ -66,7 +70,7 @@ export function debugFail(failure: string): never {
  * @param message
  */
 export function debugAssert(
-  assertion: boolean,
+  assertion: unknown,
   message: string
 ): asserts assertion {
   if (!assertion) {