fix(core): improve typings with new Observer interface

Author: jsayol

typings/app.d.ts

@@ -76,6 +76,12 @@ declare namespace firebase {
     uid : string ;
   }
 
+  interface Observer<V, E> {
+    next?: (value: V | null) => void;
+    error?: (error: E) => void;
+    complete?: () => void;
+  }
+
   function app (name ? : string ) : firebase.app.App ;
 
   var apps : ( firebase.app.App | null ) [] ;
@@ -123,8 +129,8 @@ declare namespace firebase.auth {
     currentUser : firebase.User | null ;
     fetchProvidersForEmail (email : string ) : firebase.Promise < any > ;
     getRedirectResult ( ) : firebase.Promise < any > ;
-    onAuthStateChanged (nextOrObserver : Object , error ? : (a : firebase.auth.Error ) => any , completed ? : ( ) => any ) : ( ) => any ;
-    onIdTokenChanged (nextOrObserver : Object , error ? : (a : firebase.auth.Error ) => any , completed ? : ( ) => any ) : ( ) => any ;
+    onAuthStateChanged (nextOrObserver : firebase.Observer<firebase.User, firebase.auth.Error> | ((user: firebase.User | null) => void), error ? : (a : firebase.auth.Error ) => void , completed ? : ( ) => void ) : ( ) => void ;
+    onIdTokenChanged (nextOrObserver : firebase.Observer<firebase.User, firebase.auth.Error> | ((user: firebase.User | null) => void), error ? : (a : firebase.auth.Error ) => void , completed ? : ( ) => void ) : ( ) => void ;
     sendPasswordResetEmail (email : string ) : firebase.Promise < any > ;
     signInAndRetrieveDataWithCredential (credential : firebase.auth.AuthCredential ) : firebase.Promise < any > ;
     signInAnonymously ( ) : firebase.Promise < any > ;
@@ -306,8 +312,8 @@ declare namespace firebase.messaging {
   interface Messaging {
     deleteToken (token : string ) : firebase.Promise < any > | null ;
     getToken ( ) : firebase.Promise < any > | null ;
-    onMessage (nextOrObserver : Object ) : ( ) => any ;
-    onTokenRefresh (nextOrObserver : Object ) : ( ) => any ;
+    onMessage (nextOrObserver : firebase.Observer<Object, void> | ((payload: Object) => void) ) : ( ) => any ;
+    onTokenRefresh (nextOrObserver : firebase.Observer<Object, void> | ((a: Object) => void) ) : ( ) => any ;
     requestPermission ( ) : firebase.Promise < any > | null ;
     setBackgroundMessageHandler (callback : (a : Object ) => any ) : any ;
     useServiceWorker (registration : any ) : any ;
@@ -392,7 +398,7 @@ declare namespace firebase.storage {
   interface UploadTask {
     cancel ( ) : boolean ;
     catch (onRejected : (a : Error ) => any ) : firebase.Promise < any > ;
-    on (event : firebase.storage.TaskEvent , nextOrObserver ? : null | Object , error ? : ( (a : Error ) => any ) | null , complete ? : ( ( ) => any ) | null ) : Function ;
+    on (event : firebase.storage.TaskEvent , nextOrObserver ? : firebase.Observer<firebase.storage.UploadTaskSnapshot, Error> | ((snapshot: firebase.storage.UploadTaskSnapshot) => void) , error ? : ( (a : Error ) => void ) | null , complete ? : ( ( ) => void ) | null ) : Function ;
     pause ( ) : boolean ;
     resume ( ) : boolean ;
     snapshot : firebase.storage.UploadTaskSnapshot ;

typings/firebase.d.ts

@@ -76,6 +76,12 @@ declare namespace firebase {
     uid : string ;
   }
 
+  interface Observer<V, E> {
+    next?: (value: V | null) => void;
+    error?: (error: E) => void;
+    complete?: () => void;
+  }
+
   function app (name ? : string ) : firebase.app.App ;
 
   var apps : ( firebase.app.App | null ) [] ;
@@ -123,8 +129,8 @@ declare namespace firebase.auth {
     currentUser : firebase.User | null ;
     fetchProvidersForEmail (email : string ) : firebase.Promise < any > ;
     getRedirectResult ( ) : firebase.Promise < any > ;
-    onAuthStateChanged (nextOrObserver : Object , error ? : (a : firebase.auth.Error ) => any , completed ? : ( ) => any ) : ( ) => any ;
-    onIdTokenChanged (nextOrObserver : Object , error ? : (a : firebase.auth.Error ) => any , completed ? : ( ) => any ) : ( ) => any ;
+    onAuthStateChanged (nextOrObserver : firebase.Observer<firebase.User, firebase.auth.Error> | ((user: firebase.User | null) => void), error ? : (a : firebase.auth.Error ) => void , completed ? : ( ) => void ) : ( ) => void ;
+    onIdTokenChanged (nextOrObserver : firebase.Observer<firebase.User, firebase.auth.Error> | ((user: firebase.User | null) => void), error ? : (a : firebase.auth.Error ) => void , completed ? : ( ) => void ) : ( ) => void ;
     sendPasswordResetEmail (email : string ) : firebase.Promise < any > ;
     signInAndRetrieveDataWithCredential (credential : firebase.auth.AuthCredential ) : firebase.Promise < any > ;
     signInAnonymously ( ) : firebase.Promise < any > ;
@@ -306,8 +312,8 @@ declare namespace firebase.messaging {
   interface Messaging {
     deleteToken (token : string ) : firebase.Promise < any > | null ;
     getToken ( ) : firebase.Promise < any > | null ;
-    onMessage (nextOrObserver : Object ) : ( ) => any ;
-    onTokenRefresh (nextOrObserver : Object ) : ( ) => any ;
+    onMessage (nextOrObserver : firebase.Observer<Object, void> | ((payload: Object) => void) ) : ( ) => any ;
+    onTokenRefresh (nextOrObserver : firebase.Observer<Object, void> | ((a: Object) => void) ) : ( ) => any ;
     requestPermission ( ) : firebase.Promise < any > | null ;
     setBackgroundMessageHandler (callback : (a : Object ) => any ) : any ;
     useServiceWorker (registration : any ) : any ;
@@ -392,7 +398,7 @@ declare namespace firebase.storage {
   interface UploadTask {
     cancel ( ) : boolean ;
     catch (onRejected : (a : Error ) => any ) : firebase.Promise < any > ;
-    on (event : firebase.storage.TaskEvent , nextOrObserver ? : null | Object , error ? : ( (a : Error ) => any ) | null , complete ? : ( ( ) => any ) | null ) : Function ;
+    on (event : firebase.storage.TaskEvent , nextOrObserver ? : firebase.Observer<firebase.storage.UploadTaskSnapshot, Error> | ((snapshot: firebase.storage.UploadTaskSnapshot) => void) , error ? : ( (a : Error ) => void ) | null , complete ? : ( ( ) => void ) | null ) : Function ;
     pause ( ) : boolean ;
     resume ( ) : boolean ;
     snapshot : firebase.storage.UploadTaskSnapshot ;