Fix debug initialize flag

Author: hsubox76

packages/app-check/src/api.test.ts

@@ -39,6 +39,7 @@ import * as client from './client';
 import * as storage from './storage';
 import * as internalApi from './internal-api';
 import * as indexeddb from './indexeddb';
+import * as debug from './debug';
 import { deleteApp, FirebaseApp } from '@firebase/app';
 import { CustomProvider, ReCaptchaV3Provider } from './providers';
 import { AppCheckService } from './factory';
@@ -140,18 +141,27 @@ describe('api', () => {
       expect(consoleStub.args[0][0]).to.include(token);
       self.FIREBASE_APPCHECK_DEBUG_TOKEN = undefined;
     });
-    it('warns about debug mode on second call', async () => {
+    it('does not call initializeDebugMode on second call', async () => {
       self.FIREBASE_APPCHECK_DEBUG_TOKEN = 'abcdefg';
       const consoleStub = stub(console, 'log');
+      const initializeDebugModeSpy = spy(debug, 'initializeDebugMode');
+      // First call, should call initializeDebugMode()
       initializeAppCheck(app, {
         provider: new ReCaptchaV3Provider(FAKE_SITE_KEY)
       });
+      expect(initializeDebugModeSpy).to.be.called;
+      initializeDebugModeSpy.resetHistory();
+      // Second call, should not call initializeDebugMode()
       initializeAppCheck(app, {
         provider: new ReCaptchaV3Provider(FAKE_SITE_KEY)
       });
       const token = await getDebugToken();
       expect(token).to.equal('abcdefg');
+      // Two console logs of the token, for each initializeAppCheck call.
       expect(consoleStub.args[0][0]).to.include(token);
+      expect(consoleStub.args[1][0]).to.include(token);
+      expect(consoleStub.args[1][0]).to.equal(consoleStub.args[0][0]);
+      expect(initializeDebugModeSpy).to.not.be.called;
       self.FIREBASE_APPCHECK_DEBUG_TOKEN = undefined;
     });
 

packages/app-check/src/api.ts

@@ -63,8 +63,8 @@ export function initializeAppCheck(
     initializeDebugMode();
   }
 
-  // Log a warning when `initializeAppCheck()` is called in debug mode,
-  // and show the token.
+  // Log a message containing the debug token when `initializeAppCheck()`
+  // is called in debug mode.
   if (isDebugMode()) {
     // Do not block initialization to get the token for the message.
     void getDebugToken().then(token =>

packages/app-check/src/debug.ts

@@ -46,14 +46,18 @@ export async function getDebugToken(): Promise<string> {
 
 export function initializeDebugMode(): void {
   const globals = getGlobal();
+  const debugState = getDebugState();
+  // Set to true if this function has been called, whether or not
+  // it enabled debug mode.
+  debugState.initialized = true;
+
   if (
     typeof globals.FIREBASE_APPCHECK_DEBUG_TOKEN !== 'string' &&
     globals.FIREBASE_APPCHECK_DEBUG_TOKEN !== true
   ) {
     return;
   }
 
-  const debugState = getDebugState();
   debugState.enabled = true;
   const deferredToken = new Deferred<string>();
   debugState.token = deferredToken;

packages/app-check/src/state.ts

@@ -70,6 +70,7 @@ export function clearState(): void {
   APP_CHECK_STATES.clear();
   DEBUG_STATE.enabled = false;
   DEBUG_STATE.token = undefined;
+  DEBUG_STATE.initialized = false;
 }
 
 export function getDebugState(): DebugState {