Address PR comments

Author: hsubox76

packages/app-check/src/api.test.ts

@@ -16,7 +16,7 @@
  */
 import '../test/setup';
 import { expect } from 'chai';
-import { match, spy, stub } from 'sinon';
+import { spy, stub } from 'sinon';
 import {
   setTokenAutoRefreshEnabled,
   initializeAppCheck,
@@ -128,7 +128,6 @@ describe('api', () => {
       };
       stub(indexeddb, 'writeDebugTokenToIndexedDB').callsFake(fakeWrite);
       stub(indexeddb, 'readDebugTokenFromIndexedDB').resolves(token);
-      const logStub = stub(logger.logger, 'warn');
       const consoleStub = stub(console, 'log');
       self.FIREBASE_APPCHECK_DEBUG_TOKEN = true;
       initializeAppCheck(app, {
@@ -139,13 +138,11 @@ describe('api', () => {
       // written to indexedDB.
       expect(await getDebugToken()).to.equal(token);
       expect(consoleStub.args[0][0]).to.include(token);
-      expect(logStub).to.be.calledWith(match('is in debug mode'));
-      expect(logStub).to.be.calledWith(match(token));
       self.FIREBASE_APPCHECK_DEBUG_TOKEN = undefined;
     });
     it('warns about debug mode on second call', async () => {
-      const logStub = stub(logger.logger, 'warn');
       self.FIREBASE_APPCHECK_DEBUG_TOKEN = 'abcdefg';
+      const consoleStub = stub(console, 'log');
       initializeAppCheck(app, {
         provider: new ReCaptchaV3Provider(FAKE_SITE_KEY)
       });
@@ -154,7 +151,7 @@ describe('api', () => {
       });
       const token = await getDebugToken();
       expect(token).to.equal('abcdefg');
-      expect(logStub).to.be.calledWith(match('abcdefg'));
+      expect(consoleStub.args[0][0]).to.include(token);
       self.FIREBASE_APPCHECK_DEBUG_TOKEN = undefined;
     });
 

packages/app-check/src/api.ts

@@ -36,7 +36,6 @@ import {
 } from './internal-api';
 import { readTokenFromStorage } from './storage';
 import { getDebugToken, initializeDebugMode, isDebugMode } from './debug';
-import { logger } from './logger';
 
 declare module '@firebase/component' {
   interface NameServiceMapping {
@@ -67,14 +66,13 @@ export function initializeAppCheck(
   // Log a warning when `initializeAppCheck()` is called in debug mode,
   // and show the token.
   if (isDebugMode()) {
-    logger.warn(
-      `App Check is in debug mode. To turn off debug mode, unset ` +
-        `the global variable FIREBASE_APPCHECK_DEBUG_TOKEN and ` +
-        `restart the app.`
+    // Do not block initialization to get the token for the message.
+    void getDebugToken().then(token =>
+      // Not using logger because I don't think we ever want this accidentally hidden.
+      console.log(
+        `App Check debug token: ${token}. You will need to add it to your app's App Check settings in the Firebase console for it to work.`
+      )
     );
-    // Make this a separate console statement so user will at least have the
-    // first message if the token promise doesn't resolve in time.
-    void getDebugToken().then(token => logger.warn(`Debug token is ${token}.`));
   }
 
   if (provider.isInitialized()) {

packages/app-check/src/storage.ts

@@ -87,10 +87,6 @@ export async function readOrCreateDebugTokenFromStorage(): Promise<string> {
     writeDebugTokenToIndexedDB(newToken).catch(e =>
       logger.warn(`Failed to persist debug token to IndexedDB. Error: ${e}`)
     );
-    // Not using logger because I don't think we ever want this accidentally hidden?
-    console.log(
-      `App Check debug token: ${newToken}. You will need to add it to your app's App Check settings in the Firebase console for it to work`
-    );
     return newToken;
   } else {
     return existingDebugToken;