[Multi-Tab] Spec tests for clients that gain primary lease at startup (#985)

Author: schmidt-sebastian

packages/firestore/test/unit/specs/listen_spec.test.ts

@@ -754,7 +754,7 @@ describeSpec('Listens:', [], () => {
   );
 
   specTest(
-    'Query is re-listened to after primary tab failover',
+    'Listen is re-listened to after primary tab failover',
     ['multi-client'],
     () => {
       const query = Query.atPath(path('collection'));
@@ -787,13 +787,13 @@ describeSpec('Listens:', [], () => {
     }
   );
 
-  specTest('Query is established in new primary tab', ['multi-client'], () => {
+  specTest('Listen is established in new primary tab', ['multi-client'], () => {
     const query = Query.atPath(path('collection'));
     const docA = doc('collection/a', 1000, { key: 'a' });
     const docB = doc('collection/b', 2000, { key: 'b' });
 
-    // Client 1 and Client 3 listen to the same query. When client 1 shuts
-    // down, client 2 becomes primary and takes ownership of a query it
+    // Client 0 and Client 2 listen to the same query. When client 0 shuts
+    // down, client 1 becomes primary and takes ownership of a query it
     // did not previously listen to.
     return client(0)
       .expectPrimaryState(true)
@@ -814,4 +814,36 @@ describeSpec('Listens:', [], () => {
       .client(2)
       .expectEvents(query, { added: [docB] });
   });
+
+  specTest(
+    'Listen is established in newly started primary',
+    ['multi-client'],
+    () => {
+      const query = Query.atPath(path('collection'));
+      const docA = doc('collection/a', 1000, { key: 'a' });
+      const docB = doc('collection/b', 2000, { key: 'b' });
+
+      // Client 0 executes a query on behalf of Client 1. When client 0 shuts
+      // down, client 2 starts up and becomes primary, taking ownership of the
+      // existing query.
+      return client(0)
+        .expectPrimaryState(true)
+        .client(1)
+        .userListens(query)
+        .expectEvents(query, { fromCache: true })
+        .client(0)
+        .expectListen(query)
+        .watchAcksFull(query, 1000, docA)
+        .client(1)
+        .expectEvents(query, { added: [docA] })
+        .client(0)
+        .shutdown()
+        .client(2)
+        .expectPrimaryState(true)
+        .expectListen(query, 'resume-token-1000')
+        .watchAcksFull(query, 2000, docB)
+        .client(1)
+        .expectEvents(query, { added: [docB] });
+    }
+  );
 });

packages/firestore/test/unit/specs/write_spec.test.ts

@@ -1127,4 +1127,22 @@ describeSpec('Writes:', [], () => {
         hasPendingWrites: true
       });
   });
+
+  specTest('Write is sent by newly started primary', ['multi-client'], () => {
+    return client(0)
+      .expectPrimaryState(true)
+      .client(1)
+      .expectPrimaryState(false)
+      .userSets('collection/a', { v: 1 })
+      .client(0)
+      .shutdown()
+      .client(2)
+      .expectPrimaryState(true)
+      .expectNumOutstandingWrites(1)
+      .writeAcks('collection/a', 1000, { expectUserCallback: false })
+      .client(1)
+      .expectUserCallbacks({
+        acknowledged: ['collection/a']
+      });
+  });
 });