Skip to content

Commit 4c84e10

Browse files
Remove withGcEnabled for tests that don't call unlisten (#995)
1 parent 63dd7bb commit 4c84e10

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

packages/firestore/test/unit/specs/listen_spec.test.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -627,7 +627,7 @@ describeSpec('Listens:', [], () => {
627627
specTest('Query is rejected by primary client', ['multi-client'], () => {
628628
const query = Query.atPath(path('collection'));
629629

630-
return client(0, /* withGcEnabled= */ false)
630+
return client(0)
631631
.becomeVisible()
632632
.client(1)
633633
.userListens(query)
@@ -648,7 +648,7 @@ describeSpec('Listens:', [], () => {
648648
() => {
649649
const query = Query.atPath(path('collection'));
650650

651-
return client(0, /* withGcEnabled= */ false)
651+
return client(0)
652652
.becomeVisible()
653653
.client(1)
654654
.userListens(query)
@@ -676,7 +676,7 @@ describeSpec('Listens:', [], () => {
676676
() => {
677677
const query = Query.atPath(path('collection'));
678678

679-
return client(0, /*withGcEnabled=*/ false)
679+
return client(0)
680680
.becomeVisible()
681681
.client(1)
682682
.userListens(query)
@@ -703,7 +703,7 @@ describeSpec('Listens:', [], () => {
703703
const query1 = Query.atPath(path('collection'));
704704
const query2 = Query.atPath(path('collection'));
705705

706-
return client(0, /*withGcEnabled=*/ false)
706+
return client(0)
707707
.userListens(query1)
708708
.watchAcksFull(query1, 1000)
709709
.expectEvents(query1, {})
@@ -729,7 +729,7 @@ describeSpec('Listens:', [], () => {
729729
const query = Query.atPath(path('collection'));
730730
const docA = doc('collection/a', 2000, { key: 'a' });
731731

732-
return client(0, /*withGcEnabled=*/ false)
732+
return client(0)
733733
.becomeVisible()
734734
.client(1)
735735
.userListens(query)
@@ -761,7 +761,7 @@ describeSpec('Listens:', [], () => {
761761
const docA = doc('collection/a', 1000, { key: 'a' });
762762
const docB = doc('collection/b', 2000, { key: 'b' });
763763

764-
return client(0, /*withGcEnabled=*/ false)
764+
return client(0)
765765
.expectPrimaryState(true)
766766
.client(1)
767767
.userListens(query)
@@ -795,7 +795,7 @@ describeSpec('Listens:', [], () => {
795795
// Client 1 and Client 3 listen to the same query. When client 1 shuts
796796
// down, client 2 becomes primary and takes ownership of a query it
797797
// did not previously listen to.
798-
return client(0, /*withGcEnabled=*/ false)
798+
return client(0)
799799
.expectPrimaryState(true)
800800
.userListens(query)
801801
.watchAcksFull(query, 1000, docA)

0 commit comments

Comments
 (0)