Import Spec tests #6525
Import Spec tests #6525
Conversation
Generated by 🚫 Danger |
| @@ -195,6 +195,7 @@ @implementation FSTSyncEngineTestDriver { | |||
| IndexFreeQueryEngine _queryEngine; | |||
|
|
|||
| int _snapshotsInSyncEvents; | |||
| int _waitForPendingWritesEvents; | |||
There was a problem hiding this comment.
Looks like this variable should be initialized to 0 in the init function, similar to _snapshotsInSyncEvents.
There was a problem hiding this comment.
Done (but I didn't see the other initialization, so I added that as well)
There was a problem hiding this comment.
Sorry, I mistakenly thought line 289 was part of the initialization, but it's actually in its own reset function. My Objective-C knowledge is poor -- it could be the case that primitives are set to 0 automatically, I'm not sure (it wouldn't be the case in C++). So this initialization could be redundant (though shouldn't hurt).
There was a problem hiding this comment.
Objective-C defaults all members to zero, so explicitly making that initialization is redundant.
There was a problem hiding this comment.
Thanks, Gil! Sebastian, sorry for the redundant comment.
There was a problem hiding this comment.
Removed again.
| @@ -195,6 +195,7 @@ @implementation FSTSyncEngineTestDriver { | |||
| IndexFreeQueryEngine _queryEngine; | |||
|
|
|||
| int _snapshotsInSyncEvents; | |||
| int _waitForPendingWritesEvents; | |||
There was a problem hiding this comment.
Sorry, I mistakenly thought line 289 was part of the initialization, but it's actually in its own reset function. My Objective-C knowledge is poor -- it could be the case that primitives are set to 0 automatically, I'm not sure (it wouldn't be the case in C++). So this initialization could be redundant (though shouldn't hurt).
* Import Spec tests * Init * Add recovery specs * Update FSTSyncEngineTestDriver.mm
Port of firebase/firebase-android-sdk#2000 (that's right - 2000!)