Remove duplicate logging issue. #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some combinations of iOS version, simulator/device, and Xcode version result in duplicate logs. This should remove duplicate logs while ensuring that all Firebase related logs are still shown.
paulb777
reviewed
Sep 15, 2017
| // Need to call asl_add_output_file so that the logs can appear in Xcode's console view when | ||
| // running iOS 7. Set the ASL filter mask for this output file up to debug level so that all | ||
| // messages are viewable in the console. | ||
| if (majorOSVersion == 7) { |
There was a problem hiding this comment.
Did you test on majorOSVersion 8,9,10 simulators, since this block would have been executed for them before?
paulb777
approved these changes
Sep 15, 2017
paulb777
pushed a commit
that referenced
this pull request
Sep 16, 2017
Some combinations of iOS version, simulator/device, and Xcode version result in duplicate logs. This should remove duplicate logs while ensuring that all Firebase related logs are still shown.
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
Some combinations of iOS version, simulator/device, and Xcode version result in duplicate logs. This should remove duplicate logs while ensuring that all Firebase related logs are still shown.
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
Some combinations of iOS version, simulator/device, and Xcode version result in duplicate logs. This should remove duplicate logs while ensuring that all Firebase related logs are still shown.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some combinations of iOS version, simulator/device, and Xcode version
result in duplicate logs. This should remove duplicate logs while
ensuring that all Firebase related logs are still shown.