Skip to content

Removes canHandleURL from FIRAuthInternal #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2017
Merged

Removes canHandleURL from FIRAuthInternal #235

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cf20b0
Removes canHandleURL from FIRAuthInternal
protocol86 Sep 5, 2017
eb7178b
Addresses comment
protocol86 Sep 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Example/Auth/Tests/FIRPhoneAuthProviderTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,9 @@ - (void)testVerifyPhoneNumberUIDelegate {
NSMutableString *fakeRedirectURLString =
[NSMutableString stringWithString:kFakeRedirectURLStringWithoutReCAPTCHAToken];
[fakeRedirectURLString appendString:kFakeReCAPTCHAToken];
[[_mockAuth authURLPresenter] canHandleURL:[NSURL URLWithString:fakeRedirectURLString]];

OCMExpect([_mockAuth canHandleURL:OCMOCK_ANY]).andReturn([[_mockAuth authURLPresenter]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The canHandleURL: seems to get called too early.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

canHandleURL:[NSURL URLWithString:fakeRedirectURLString]]);
});
// Expect view controller dismissal by UIDelegate.
OCMExpect([mockUIDelegate dismissViewControllerAnimated:OCMOCK_ANY completion:OCMOCK_ANY]).
Expand Down
12 changes: 0 additions & 12 deletions Firebase/Auth/Source/FIRAuth_Internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,18 +124,6 @@ NS_ASSUME_NONNULL_BEGIN
*/
- (BOOL)signOutByForceWithUserID:(NSString *)userID error:(NSError *_Nullable *_Nullable)error;

/** @fn canHandleURL:
@brief Whether the specific URL is handled by @c FIRAuth .
@param url The URL received by the application delegate from any of the openURL method.
@return Whether or the URL is handled. YES means the URL is for Firebase Auth
so the caller should ignore the URL from further processing, and NO means the
the URL is for the app (or another libaray) so the caller should continue handling
this URL as usual.
@remarks If swizzling is disabled, URLs received by the application delegate must be forwarded
to this method for phone number auth to work.
*/
- (BOOL)canHandleURL:(nonnull NSURL *)url;

@end

NS_ASSUME_NONNULL_END