Skip to content

Add ARCore to Podfile #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add ARCore to Podfile #2208

wants to merge 2 commits into from

Conversation

mikehaney24
Copy link
Contributor

@mikehaney24 mikehaney24 commented Dec 21, 2018 •
edited
Loading

Adds the ARCore cocoapod to the symbol collision checker.

@mikehaney24 mikehaney24 requested a review from paulb777 December 21, 2018 02:44
paulb777
paulb777 requested changes Dec 21, 2018
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reformat and then lgtm

paulb777
paulb777 requested changes Dec 21, 2018
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the SymbolCollision test didn't run on travis. I suspect that the Podfile needs to be added to the if_changes pattern. sorry I missed this earlier

paulb777
paulb777 requested changes Dec 21, 2018
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it manually and ARCore has Clearcut collisions with FirebasePerformance and other collisions with GoogleCast

@paulb777
Copy link
Member

Symbol Collision tests run on if_cron - not if_changed. However since ARCore doesn't work, I did #2210.

@mikehaney24
Copy link
Contributor Author

Should I just close this PR?

@paulb777
Copy link
Member

Yes. Done.

@paulb777 paulb777 closed this Dec 21, 2018
@mikehaney24 mikehaney24 deleted the mph-arcorepodfile branch January 18, 2019 21:11
@firebase firebase locked and limited conversation to collaborators Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 requested changes

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikehaney24 @paulb777 @ryanwilson @googlebot