Skip to content

Update Auth samples to sync with internal changes #2056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Update Auth samples to sync with internal changes #2056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions Example/Auth/ApiTests/FirebaseAuthApiTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@

#ifdef NO_NETWORK
#import "ITUIOSTestUtil.h"
#import "ioReplayer/IORManager.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is not removed in the cl?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an oversight that it wasn't removed since ioReplayer became unsupported.

Separately this file has not been kept buildable and we should either decide to fix it and include it in travis testing or delete it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'll try to fix it.

#import "ioReplayer/IORTestCase.h"
#endif

#import <GTMSessionFetcher/GTMSessionFetcher.h>
Expand Down Expand Up @@ -93,11 +91,8 @@
#define SKIP_IF_ON_MOBILE_HARNESS
#endif

#ifdef NO_NETWORK
@interface ApiTests : IORTestCase
#else
@interface ApiTests : XCTestCase
#endif

@end

@implementation ApiTests
Expand Down
8 changes: 0 additions & 8 deletions Example/Auth/EarlGreyTests/FirebaseAuthEarlGreyTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@
#import <FirebaseCore/FIRApp.h>
#import "FirebaseAuth.h"

#ifdef NO_NETWORK
#import "ioReplayer/IORTestCase.h"
#endif

/** The url for obtaining a valid custom token string used to test BYOAuth. */
static NSString *const kCustomTokenUrl = @"https://fb-sa-1211.appspot.com/token";

Expand All @@ -38,11 +34,7 @@

static NSTimeInterval const kWaitForElementTimeOut = 5;

#ifdef NO_NETWORK
@interface BasicUITest : IORTestCase
#else
@interface BasicUITest :XCTestCase
#endif
@end

/** Convenience function for EarlGrey tests. */
Expand Down