Skip to content

style.sh && merge master #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 47 commits into from
Nov 1, 2018
Merged

Conversation

rsgowman
Copy link
Member

No description provided.

ryanwilson and others added 30 commits October 17, 2018 11:25
typeof() is not supported in some C language dialects which causes
issues when integrating FDL in projects that do use non-GNU compiler modes.

For example, this causes problems when building in some versions of Unity
firebase/quickstart-unity#228
typeof() is not supported in some C language dialects which causes
issues when integrating FDL in projects that do use non-GNU compiler modes.

For example, this causes problems when building in some versions of Unity
firebase/quickstart-unity#228
DynamicLinks patch version for c99 compatibility fix
Lock reads and writes to session map
* Wrap diagnostics notification in collection flag check.

Some of the diagnostics notifications were missed and not covered by
the data collection flag.

* Remove redundant notification call, move Core diagnostics API call.

* Removed configure with no options test.
* Remove unnecessary notification flag.

This was added when the Google pod could configure Firebase but the
Google pod is deprecated and can only work with Firebase 3.X. These
flags and conditional checks can be safely removed.

* Resolve issues from commit split.

* Style fixes.
* Reduce singleton usage in FIRApp tests.

There have been some issues while creating new tests of conflicts with
mocks of classes and instances, this should alleviate some of those
conflicts in the future.

* Remove bad style changes.

* Use default app name flag instead of local variable.
* Trigger travis for Firestore podspec changes
`typeof` is only defined if you compile with GNU extensions, while
`__typeof__` is always available.

This is the Firestore equivalent of #1982.

Note that Firestore won't yet build in this mode because among other
things the Objective-C gRPC still uses `typeof`. Once we eliminate that
dependency this might become possible.
* SafariServices not available on tvOS and not used on osx
Note that c++0x is how Xcode spells c++11.

Also fix an issue where we were accidentally using a C++14 feature.
…g integration test with actual server instead of hexa. (#2007)
@googlebot

This comment has been minimized.

@googlebot

This comment has been minimized.

@morganchen12

This comment has been minimized.

Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned rsgowman and unassigned wilhuff Oct 31, 2018
@rsgowman rsgowman merged commit cbfcb8a into nanopb-master Nov 1, 2018
@rsgowman rsgowman deleted the rsgowman/nanopb_master_fixes branch November 1, 2018 14:48
@firebase firebase locked and limited conversation to collaborators Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.