-
Notifications
You must be signed in to change notification settings - Fork 1.6k
gRPC: replace Objective-C implementation with the new C++ implementation #1968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
805b673
gRPC: add support for SSL disabled to `GrpcConnection`.
var-const 839f408
gRPC: make gRPC calls using the C++ implementation:
var-const a93b783
C++: port `MockWatchStream` and `MockWriteStream` to C++.
var-const 4fe32a1
No longer generate Objective-C gRPC service definitions from protos.
var-const 0ea6fcc
Remove all references to Objective-C gRPC client.
var-const 21d30b6
Use local certificate for now
var-const 7f60ad0
Fix/improve ASCII conversion
var-const feb0285
Review feedback
var-const 8332a5f
style.sh
var-const ab6df2e
Appease linter
var-const 9f9d94d
Undo accidental change
var-const 555e1d8
missing word
var-const 6f0d4e6
add comment
var-const 84e454b
Remove leftover reference to Objective-C gRPC
var-const c96f670
More using declarations
var-const e2e53b0
typo
var-const 1bcfc0f
Use Path instead of plain string
var-const 2d68f12
Missed include
var-const 80a938e
Remove redundant word
var-const 9c1dec6
Remove ASCII conversion when loading certificates, it is not necessary
var-const d638062
Compilation fix
var-const abceb14
Review feedback
var-const dc872a7
Tweak comment
var-const c4d99d7
Move certificate to Firestore/etc/roots.pem
var-const 90c3b43
Forgotten file
var-const cf856e6
Review feedback
var-const 33555c9
Forgotten comment
var-const f1c8f5d
Fix test
var-const 1a5acc7
Review feedback
var-const 101b611
Fix flaky test
var-const 1f6ee21
Merge branch 'master' into varconst/grpc-integr82
var-const 348a924
Fix bad port
var-const File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GrpcConnection
should take care of it now inShutdown
.