-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Adding unknownDocument #1948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding unknownDocument #1948
Changes from 4 commits
9feb291
0b6ac70
02ba570
819d497
0ad277e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,17 @@ | ||
// Copyright 2018 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
syntax = "proto3"; | ||
|
||
package firestore.client; | ||
|
@@ -22,6 +36,7 @@ message Target { | |
// The last snapshot version received from the Watch Service for this target. | ||
// | ||
// This is the same value as TargetChange.read_time | ||
// https://github.com/googleapis/googleapis/blob/master/google/firestore/v1beta1/firestore.proto#L734 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't much care, but this comment could go stale and end up pointing to the wrong thing if firestore.proto is changed in the future. Solutions:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Leaving as is, since this URL exists in the Android repo. I wanted both files to be the same |
||
google.protobuf.Timestamp snapshot_version = 2; | ||
|
||
// An opaque, server-assigned token that allows watching a query to be | ||
|
@@ -38,6 +53,7 @@ message Target { | |
// the client should use the snapshot_version for its own purposes. | ||
// | ||
// This is the same value as TargetChange.resume_token | ||
// https://github.com/googleapis/googleapis/blob/master/google/firestore/v1beta1/firestore.proto#L722 | ||
bytes resume_token = 3; | ||
|
||
// A sequence number representing the last time this query was listened to, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: consider fixing the name in the comment too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done