Skip to content

Backporting reviewer suggested comments from cl/214509458 #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2018

Conversation

rsgowman
Copy link
Member

@rsgowman rsgowman commented Oct 3, 2018

This is the iOS port of
firebase/firebase-android-sdk#49

Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@wilhuff wilhuff changed the title Backporting reviewer suggested comments from http://cl/214509458 Backporting reviewer suggested comments from cl/214509458 Oct 3, 2018
@wilhuff wilhuff assigned rsgowman and unassigned wilhuff Oct 3, 2018
@rsgowman rsgowman merged commit f24f453 into master Oct 3, 2018
@rsgowman rsgowman deleted the rsgowman/changelog_update branch October 3, 2018 18:18
@firebase firebase locked and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants