turn on travis testing for in-app messaging display #1887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
requested changes
Sep 27, 2018
| @@ -0,0 +1,25 @@ | |||
| /* | |||
There was a problem hiding this comment.
This file should be part of the public headers so that static libraries work out of the box for anyone installing the pod that way.
There was a problem hiding this comment.
actually, fiam display already has a public umbrella file which can be used as the bridge header for this swift sample project. Removing this BridgeHeader.h file.
thanks for the reminder.
scripts/build.sh
Outdated
| @@ -204,6 +204,16 @@ case "$product-$method-$platform" in | |||
| test | |||
| fi | |||
|
|
|||
| # Run UI tests on both iPad and iphone simultors | |||
There was a problem hiding this comment.
It looks like the IAM tests roughly double the running time of the first build stage.
Given that, IAM should be separated into its own set stage like Firestore is.
There was a problem hiding this comment.
done with the new commits
paulb777
approved these changes
Sep 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since InAppMessaging 0.12.0 has been released, we can now run ui tests for in-app messaging display publicly. So turn on testing in our scripts