Skip to content

Add GetFileSize to filesystem.h #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2018
Merged

Add GetFileSize to filesystem.h #1882

merged 2 commits into from
Oct 1, 2018

Conversation

gsoltis
Copy link

@gsoltis gsoltis commented Sep 26, 2018

Does not include windows port

Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though see comments in filesystem.h

@wilhuff wilhuff assigned gsoltis and unassigned wilhuff Oct 1, 2018
@gsoltis gsoltis merged commit 3f60f8d into master Oct 1, 2018
@gsoltis gsoltis deleted the gsoltis/get_file_size branch October 1, 2018 18:11
@firebase firebase locked and limited conversation to collaborators Oct 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants