Allow GoogleServices-Info.plist to configure Firestore integration tests #1822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelehen
approved these changes
Sep 14, 2018
There was a problem hiding this comment.
LGTM though:
- Do we want to help developers set this up? (add instructions to our README, or go as far as the JS SDK and have a helper script to create the config file)
- In the case of no GoogleServiceInfo file (and no cert), do we want to have a helpful log message telling the dev to get one?
|
PTAL |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings iOS into line with the other platforms that also test against prod by default and brings Firestore iOS into line with the other iOS projects which require a similar configuration.