Skip to content

Remove stale comment from WatchChangeAggregator changes. #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions Firestore/Source/Remote/FSTRemoteStore.mm
Original file line number Diff line number Diff line change
Expand Up @@ -82,21 +82,6 @@ @interface FSTRemoteStore () <FSTWatchStreamDelegate, FSTWriteStreamDelegate>
@property(nonatomic, strong, readonly)
NSMutableDictionary<FSTBoxedTargetID *, FSTQueryData *> *listenTargets;

/**
* A mapping of targetId to pending acks needed.
*
* If a targetId is present in this map, then we're waiting for watch to
* acknowledge a removal or addition of the target. If a target is not in this
* mapping, and it's in the listenTargets map, then we consider the target to
* be active.
*
* We increment the count here everytime we issue a request over the stream to
* watch or unwatch. We then decrement the count everytime we get a target
* added or target removed message from the server. Once the count is equal to
* 0 we know that the client and server are in the same state (once this state
* is reached the targetId is removed from the map to free the memory).
*/

@property(nonatomic, assign) FSTBatchID lastBatchSeen;

@property(nonatomic, strong, readonly) FSTOnlineStateTracker *onlineStateTracker;
Expand Down