In FSTLocalDocumentsView, search for all batches affecting a set of keys in one go #1505
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,7 @@ | |
| #import <FirebaseFirestore/FirebaseFirestore.h> | ||
|
|
||
| #import <XCTest/XCTest.h> | ||
| #include <mach/mach.h> | ||
|
|
||
| #import "Firestore/Example/Tests/Util/FSTEventAccumulator.h" | ||
| #import "Firestore/Example/Tests/Util/FSTIntegrationTestCase.h" | ||
|
|
@@ -323,4 +324,53 @@ - (void)testUpdateNestedFields { | |
| [self awaitExpectations]; | ||
| } | ||
|
|
||
| // Returns how much memory the test application is currently using, in megabytes (fractional part is | ||
| // truncated), or -1 if the OS call fails. | ||
| // TODO(varconst): move the helper function and the test into a new test target for performance | ||
| // testing. | ||
| long long getCurrentMemoryUsedInMb() { | ||
|
There was a problem hiding this comment. Note: there is also something like performance tests in There was a problem hiding this comment. Also, free functions should start with an initial capital. |
||
| mach_task_basic_info taskInfo; | ||
| mach_msg_type_number_t taskInfoSize = MACH_TASK_BASIC_INFO_COUNT; | ||
| const auto errorCode = | ||
| task_info(mach_task_self(), MACH_TASK_BASIC_INFO, (task_info_t)&taskInfo, &taskInfoSize); | ||
| if (errorCode == KERN_SUCCESS) { | ||
| const int bytesInMegabyte = 1000 * 1000; | ||
| return taskInfo.resident_size / bytesInMegabyte; | ||
| } | ||
| return -1; | ||
| } | ||
|
|
||
| - (void)testReasonableMemoryUsageForLotsOfMutations { | ||
| XCTestExpectation *expectation = | ||
| [self expectationWithDescription:@"testReasonableMemoryUsageForLotsOfMutations"]; | ||
|
|
||
| FIRDocumentReference *mainDoc = [self documentRef]; | ||
| FIRWriteBatch *batch = [mainDoc.firestore batch]; | ||
|
|
||
| // >= 500 mutations will be rejected, so use 500-1 mutations | ||
| for (int i = 0; i != 500 - 1; ++i) { | ||
| FIRDocumentReference *nestedDoc = [[mainDoc collectionWithPath:@"nested"] documentWithAutoID]; | ||
| // The exact data doesn't matter; what is important is the large number of mutations. | ||
| [batch setData:@{ | ||
| @"a" : @"foo", | ||
| @"b" : @"bar", | ||
| } | ||
| forDocument:nestedDoc]; | ||
| } | ||
|
|
||
| const long long memoryUsedBeforeCommitMb = getCurrentMemoryUsedInMb(); | ||
| XCTAssertNotEqual(memoryUsedBeforeCommitMb, -1); | ||
| [batch commitWithCompletion:^(NSError *_Nullable error) { | ||
| XCTAssertNil(error); | ||
| const long long memoryUsedAfterCommitMb = getCurrentMemoryUsedInMb(); | ||
| XCTAssertNotEqual(memoryUsedAfterCommitMb, -1); | ||
| const long long memoryDeltaMb = memoryUsedAfterCommitMb - memoryUsedBeforeCommitMb; | ||
| // This by its nature cannot be a precise value. A regression would be on the scale of 500Mb. | ||
| XCTAssertLessThan(memoryDeltaMb, 150); | ||
|
There was a problem hiding this comment. Is this the same for both 32 and 64-bit builds? There was a problem hiding this comment. I tried it using two simulators in debug mode:
I don't have a real device handy, but I can try to find one if you'd like. |
||
|
|
||
| [expectation fulfill]; | ||
| }]; | ||
| [self awaitExpectations]; | ||
| } | ||
|
|
||
| @end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should avoid
long long. Probably this can beint64_t.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.