Add spec test support for target-scoped resume tokens #1498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
force-pushed
the
mrschmidt-specsnapshot
branch
from
9fbc5a6 to
24370d3
Compare
rsgowman
approved these changes
Jul 6, 2018
| "steps": [ | ||
| { | ||
| "userListen": [ | ||
| 2, |
There was a problem hiding this comment.
(same comment as the android PR)
There was a problem hiding this comment.
I would like to punt on this for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the spec tests to treat watch snapshots as separate messages, which allows us to apply resume token on a per-target basis.
Port of firebase/firebase-js-sdk#969 / https://github.com/FirebasePrivate/firebase-android-sdk/pull/95
This also pulls in Greg's recent Spec test changes that haven't been ported (this are comment/tag-only changes in the generated JSON).