Skip to content

Refactored Number Coding in FunctionsSerializer #14889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2025

Conversation

yakovmanshin
Copy link
Contributor

  • Introduced WrappedNumber as a type-safe wrapper for numeric values which have to be encoded / decoded to fit JS limits
  • Since numbers other than big integers don’t need special encoding, it’s not necessary to process them separately for each type—all numbers except q and Q are returned as is (just as before)
  • For decoding, wrapped numbers are parsed using Swift types Int and UInt
  • These changes further reduce the usage of Objective-C types, and make it easier to (de)serialize Functions payloads using Codable in the future

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

* Introduced `WrappedNumber` as a type-safe wrapper for numeric values which have to be encoded / decoded to fit JS limits
* Since numbers other than big integers don’t need special encoding, it’s not necessary to process them separately for each type—all numbers except `q` and `Q` are returned as is (just as before)
* For decoding, wrapped numbers are parsed using Swift types `Int` and `UInt`
* These changes further reduce the usage of Objective-C types, and make it easier to (de)serialize Functions payloads using `Codable` in the future
@yakovmanshin yakovmanshin force-pushed the functions-number-coding branch from ddc6d06 to 40bd5eb Compare May 25, 2025 09:30
@ncooke3 ncooke3 self-assigned this May 27, 2025
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @yakovmanshin, for the contribution!

@ncooke3 ncooke3 merged commit 0004edb into firebase:main Jun 3, 2025
59 checks passed
@yakovmanshin yakovmanshin deleted the functions-number-coding branch June 3, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants