Skip to content

Disable failing didReceiveRemoteNotification tests(#1451) #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Disable failing didReceiveRemoteNotification tests(#1451) #1452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Example/Messaging/Tests/FIRMessagingRemoteNotificationsProxyTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,12 +164,14 @@ - (void)testSwizzlingAppDelegate {
- (void)testSwizzledIncompleteAppDelegateRemoteNotificationMethod {
IncompleteAppDelegate *incompleteAppDelegate = [[IncompleteAppDelegate alloc] init];
[self.mockProxy swizzleAppDelegateMethods:incompleteAppDelegate];
#ifdef BUG_1451
SEL selector = @selector(application:didReceiveRemoteNotification:);
XCTAssertTrue([incompleteAppDelegate respondsToSelector:selector]);
[incompleteAppDelegate application:OCMClassMock([UIApplication class])
didReceiveRemoteNotification:@{}];
// Verify our swizzled method was called
OCMVerify(FCM_swizzle_appDidReceiveRemoteNotification);
#endif
}

// If the remote notification with fetch handler is NOT implemented, we will force-implement
Expand All @@ -181,8 +183,10 @@ - (void)testIncompleteAppDelegateRemoteNotificationWithFetchHandlerMethod {
@selector(application:didReceiveRemoteNotification:fetchCompletionHandler:);
XCTAssertFalse([incompleteAppDelegate respondsToSelector:remoteNotificationWithFetchHandler]);

#ifdef BUG_1451
SEL remoteNotification = @selector(application:didReceiveRemoteNotification:);
XCTAssertTrue([incompleteAppDelegate respondsToSelector:remoteNotification]);
#endif
}

- (void)testSwizzledAppDelegateRemoteNotificationMethods {
Expand Down