Skip to content

FIRQueryTests.mm: improve the test that resumes a query with existence filter to actually validate the existence filter #11209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
May 5, 2023

Conversation

dconeybe
Copy link
Contributor

This PR improves the test testResumingAQueryShouldUseExistenceFilterToDetectDeletes() in FIRQueryTests.mm, which was added by the previous PR #10974, to also validate that the existence filter sent from Watch was correct. This was achieved by adding some test-only "hooks" into the SDK's internals that enable the test to "listen" for existence filter mismatches. This is a port of firebase/firebase-js-sdk#7149 and firebase/firebase-android-sdk#4813.

#no-changelog

@dconeybe dconeybe self-assigned this Apr 28, 2023
@dconeybe dconeybe changed the base branch from master to dconeybe/QueryExistenceFilterTest April 28, 2023 20:33
@google-oss-bot
Copy link

google-oss-bot commented Apr 28, 2023

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.06% (cd0456e) to 88.08% (e9be944) by +0.02%.

    FilenameBase (cd0456e)Merge (e9be944)Diff
    ordered_code.cc94.39%93.90%-0.49%
    remote_event.cc97.10%97.12%+0.02%
    task.cc93.91%96.52%+2.61%
    testing_hooks.cc?100.00%?
    write_stream.cc94.37%91.55%-2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/uS4xDH7h2l.html

Base automatically changed from dconeybe/QueryExistenceFilterTest to master May 2, 2023 15:32
@google-oss-bot
Copy link

google-oss-bot commented May 2, 2023

Size Report 1

Affected Products

  • FirebaseFirestore

    TypeBase (484ca20)Merge (d8f9cb4)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5boRXb9qCb.html

@dconeybe dconeybe marked this pull request as ready for review May 3, 2023 15:37
@dconeybe dconeybe requested a review from milaGGL May 3, 2023 17:06
@dconeybe dconeybe merged commit a00925f into master May 5, 2023
@dconeybe dconeybe deleted the dconeybe/QueryExistenceFilterTest2 branch May 5, 2023 18:58
@firebase firebase locked and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants