Skip to content

Firestore Spec Tests: Port JS PR 7257 (use strings for targetPurpose) #11191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 26, 2023
22 changes: 11 additions & 11 deletions Firestore/Example/Tests/SpecTests/FSTSpecTests.mm
Original file line number Diff line number Diff line change
Expand Up @@ -327,18 +327,18 @@ - (SnapshotVersion)parseVersion:(NSNumber *_Nullable)version {
return Version(version.longLongValue);
}

- (QueryPurpose)parseQueryPurpose:(NSNumber *)value {
switch ([value intValue]) {
case 0:
return QueryPurpose::Listen;
case 1:
return QueryPurpose::ExistenceFilterMismatch;
case 3:
return QueryPurpose::LimboResolution;
default:
XCTFail(@"unknown query purpose value: %@", value);
return QueryPurpose::Listen;
- (QueryPurpose)parseQueryPurpose:(NSString *)value {
if ([value isEqualToString:@"TargetPurposeListen"]) {
return QueryPurpose::Listen;
}
if ([value isEqualToString:@"TargetPurposeExistenceFilterMismatch"]) {
return QueryPurpose::ExistenceFilterMismatch;
}
if ([value isEqualToString:@"TargetPurposeLimboResolution"]) {
return QueryPurpose::LimboResolution;
}
XCTFail(@"unknown query purpose value: %@", value);
return QueryPurpose::Listen;
}

- (DocumentViewChange)parseChange:(NSDictionary *)jsonDoc ofType:(DocumentViewChange::Type)type {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1179,7 +1179,7 @@
}
],
"resumeToken": "",
"targetPurpose": 3
"targetPurpose": "TargetPurposeLimboResolution"
},
"2": {
"queries": [
Expand Down
Loading