-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Create bloom filter class header filer #10841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
milaGGL
merged 6 commits into
mila/BloomFilter
from
mila/BloomFilter-create-BloomFilter-class
Feb 21, 2023
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
/* | ||
* Copyright 2023 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
#ifndef FIRESTORE_CORE_SRC_REMOTE_BLOOM_FILTER_H_ | ||
#define FIRESTORE_CORE_SRC_REMOTE_BLOOM_FILTER_H_ | ||
|
||
#include <string> | ||
#include <vector> | ||
#include "absl/strings/string_view.h" | ||
|
||
namespace firebase { | ||
namespace firestore { | ||
namespace remote { | ||
|
||
class BloomFilter final { | ||
public: | ||
BloomFilter(std::vector<uint8_t> bitmap, int32_t padding, int32_t hash_count); | ||
|
||
// Copyable & movable. | ||
BloomFilter(const BloomFilter&) = default; | ||
BloomFilter(BloomFilter&&) = default; | ||
BloomFilter& operator=(const BloomFilter&) = default; | ||
BloomFilter& operator=(BloomFilter&&) = default; | ||
|
||
/** | ||
* Check whether the given string is a possible member of the bloom filter. It | ||
* might return false positive result, ie, the given string is not a member of | ||
* the bloom filter, but the method returned true. | ||
* | ||
* @param value the string to be tested for membership. | ||
* @return true if the given string might be contained in the bloom filter, or | ||
* false if the given string is definitely not contained in the bloom filter. | ||
*/ | ||
bool MightContain(absl::string_view value) const; | ||
|
||
// Get the `bit_count_` field. Used for testing purpose. | ||
int32_t bit_count() const { | ||
return bit_count_; | ||
} | ||
|
||
private: | ||
// The number of bits in the bloom filter. Guaranteed to be non-negative, and | ||
// less than the max number of bits `bitmap_` can represent, i.e., | ||
// bitmap_.size() * 8. | ||
int32_t bit_count_ = 0; | ||
|
||
// The number of hash functions used to construct the filter. Guaranteed to be | ||
// non-negative. | ||
int32_t hash_count_ = 0; | ||
|
||
// Bloom filter's bitmap. | ||
std::vector<uint8_t> bitmap_; | ||
}; | ||
|
||
} // namespace remote | ||
} // namespace firestore | ||
} // namespace firebase | ||
|
||
#endif // FIRESTORE_CORE_SRC_REMOTE_BLOOM_FILTER_H_ |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.