Skip to content

Update protos. #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 12, 2018
Merged

Update protos. #1075

merged 3 commits into from
Apr 12, 2018

Conversation

mikelehen
Copy link
Contributor

This updates and re-builds our protos, broken into 3 commits if it's easier to review that way.

@mikelehen mikelehen requested a review from wilhuff April 12, 2018 14:57
wilhuff
wilhuff approved these changes Apr 12, 2018
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned mikelehen and unassigned wilhuff Apr 12, 2018
@mikelehen mikelehen merged commit 6f2ef7d into master Apr 12, 2018
@mikelehen mikelehen deleted the mikelehen/update-protos branch April 12, 2018 16:08
@mikelehen mikelehen mentioned this pull request Apr 20, 2018
Merged
minafarid pushed a commit to minafarid/firebase-ios-sdk that referenced this pull request Jun 6, 2018
@mikelehen
Update protos. (firebase#1075)
986822e
@firebase firebase locked and limited conversation to collaborators Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@mikelehen mikelehen

Labels
api: firestore cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikelehen @wilhuff @googlebot