Merge branch 'master' into bs-appauthcleanup

* master: (26 commits)
  Functions Interop (#2113)
  Add a travis cron job for CocoaPod symbol collision testing (#2154)
  Save schema version on downgrade, add test to verify (#2153)
  Silence Storage Unit Test `nil` warning. (#2150)
  Update versions for Release 5.14.0 (#2145)
  gRPC: fix cases where gRPC call could be finished twice (#2146)
  Fix Swizzler test warnings (#2144)
  Update Auth CHANGELOG.md (#2128)
  Make fuzz tests optional until they pass (#2143)
  Add support of Game Center sign in (#2127)
  Add test for deprecated FDLURLComponents init API. (#2133)
  fix a typo in integration test (#2131)
  Make fuzzing less verbose to avoid exceeding Travis log limit (#2126)
  Move to `domainURIPrefix` for FIRDynamicLinkComponents (#2119)
  Carthage instructions for new gRPCCertificates.bundle location (#2132)
  Fix pod lib lint GoogleUtilities.podspec --use-libraries regression (#2130)
  Avoid using default FIROptions directly. (#2124)
  Changelog entry for LRU GC (#2122)
  Revert "Add Firebase Source to Header Search Path" (#2123)
  Custom fdl domain (#2121)
  ...

Author: bstpierr

.travis.yml

@@ -112,6 +112,15 @@ jobs:
         # The travis_wait is necessary because the command takes more than 10 minutes.
         - travis_wait ./scripts/if_cron.sh ./scripts/pod_lib_lint.sh FirebaseFirestore.podspec --use-libraries --allow-warnings --no-subspecs
 
+    # Daily test for symbol collisions between Firebase and CocoaPods.
+    - stage: test
+      env:
+        - PROJECT=SymbolCollision PLATFORM=iOS METHOD=xcodebuild
+      before_install:
+        - ./scripts/if_cron.sh ./scripts/install_prereqs.sh
+      script:
+        - ./scripts/if_cron.sh ./scripts/build.sh $PROJECT $PLATFORM $METHOD
+
     # Alternative platforms
 
     # Xcode 9
@@ -248,6 +257,7 @@ jobs:
       script:
         - ./scripts/if_changed.sh ./scripts/build.sh $PROJECT $PLATFORM $METHOD
 
+  allow_failures:
     # Run fuzz tests only on cron jobs.
     - stage: test
       env:
@@ -262,7 +272,6 @@ jobs:
     # need to make them fatal for the purposes of the test run.
 
   # TODO(varconst): disallow sanitizers to fail once we fix all existing issues.
-  allow_failures:
     - env:
       - PROJECT=Firestore PLATFORM=macOS METHOD=cmake SANITIZERS=asan
     - env:

Carthage.md

@@ -63,7 +63,7 @@ binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseStorageBinary.jso
     into the Xcode project and make sure they're added to the
     `Copy Bundle Resources` Build Phase :
     - For Firestore:
-        - ./Carthage/Build/iOS/gRPC.framework/gRPCCertificates.bundle
+        - ./Carthage/Build/iOS/FirebaseFirestore.framework/gRPCCertificates.bundle
     - For Invites:
         - ./Carthage/Build/iOS/FirebaseInvites.framework/GoogleSignIn.bundle
         - ./Carthage/Build/iOS/FirebaseInvites.framework/GPPACLPickerResources.bundle

Example/Auth/Sample/MainViewController.m

@@ -17,6 +17,7 @@
 #import "MainViewController.h"
 
 #import <objc/runtime.h>
+#import <GameKit/GameKit.h>
 
 #import <FirebaseCore/FIRApp.h>
 #import <FirebaseCore/FIRAppInternal.h>
@@ -25,6 +26,7 @@
 #import "AppManager.h"
 #import "AuthCredentials.h"
 #import "FIRAdditionalUserInfo.h"
+#import "FIRGameCenterAuthProvider.h"
 #import "FIROAuthProvider.h"
 #import "FIRPhoneAuthCredential.h"
 #import "FIRPhoneAuthProvider.h"
@@ -589,11 +591,41 @@
 static NSString *const kPhoneNumberSignInReCaptchaTitle = @"Sign in With Phone Number";
 
 /** @var kVerifyIOSClientTitle
- @brief The title for button to verify iOS client.
+    @brief The title for button to verify iOS client.
  */
 static NSString *const kVerifyIOSClientTitle = @"Verify iOS client";
 
-/** @var kIsNewUserToggleTitle
+/** @var kGameCenterAuthSectionTitle
+    @brief The title for the section of Game Center
+ */
+static NSString *const kGameCenterAuthSectionTitle = @"Game Center";
+
+/** @var kLogInWithSystemGameCenterTitle
+    @brief The title for the button to log into the Game Center account
+ */
+static NSString *const kLogInWithSystemGameCenterTitle = @"Log In System Game Center";
+
+/** @var kSignInWithGameCenterTitle
+    @brief The title for the button to sign in with Game Center
+ */
+static NSString *const kSignInWithGameCenterTitle = @"Sign in Game Center";
+
+/** @var kLinkWithGameCenterTitle
+    @brief The title for the button to link with Game Center
+ */
+static NSString *const kLinkWithGameCenterTitle = @"Link Game Center";
+
+/** @var kUnlinkWithGameCenterTitle
+    @brief The title for the button to unlink with Game Center
+ */
+static NSString *const kUnlinkWithGameCenterTitle = @"Unlink Game Center";
+
+/** @var kReauthenticateWithGameCenterTitle
+    @brief The title for the button to reauthenticate with Game Center
+ */
+static NSString *const kReauthenticateWithGameCenterTitle = @"Reauthenticate Game Center";
+
+/** @var kNewOrExistingUserToggleTitle
     @brief The title for button to enable new or existing user toggle.
  */
 static NSString *const kNewOrExistingUserToggleTitle = @"New or Existing User Toggle";
@@ -707,6 +739,8 @@ - (id)initWithNibName:(nullable NSString *)nibNameOrNil bundle:(nullable NSBundl
 }
 
 - (void)viewDidLoad {
+  [super viewDidLoad];
+
   // Give us a circle for the image view:
   _userInfoTableViewCell.userInfoProfileURLImageView.layer.cornerRadius =
       _userInfoTableViewCell.userInfoProfileURLImageView.frame.size.width / 2.0f;
@@ -745,6 +779,20 @@ - (void)updateTable {
                                              _isNewUserToggleOn = !_isNewUserToggleOn;
                                              [self updateTable]; }],
       ]],
+      [StaticContentTableViewSection sectionWithTitle:kGameCenterAuthSectionTitle cells:@[
+        [StaticContentTableViewCell cellWithTitle:kLogInWithSystemGameCenterTitle
+                                          action:^{ [weakSelf logInWithSystemGameCenter]; }],
+        [StaticContentTableViewCell cellWithTitle:kSignInWithGameCenterTitle
+                                          action:^{ [weakSelf signInWithGameCenter]; }],
+        [StaticContentTableViewCell cellWithTitle:kLinkWithGameCenterTitle
+                                          action:^{ [weakSelf linkWithGameCenter]; }],
+        [StaticContentTableViewCell cellWithTitle:kUnlinkWithGameCenterTitle
+                                          action:^{
+                                            [weakSelf unlinkFromProvider:FIRGameCenterAuthProviderID completion:nil];
+                                          }],
+        [StaticContentTableViewCell cellWithTitle:kReauthenticateWithGameCenterTitle
+                                          action:^{ [weakSelf reauthenticateWithGameCenter]; }],
+        ]],
       [StaticContentTableViewSection sectionWithTitle:kPhoneAuthSectionTitle cells:@[
         [StaticContentTableViewCell cellWithTitle:kPhoneNumberSignInReCaptchaTitle
                                            action:^{ [weakSelf signInWithPhoneNumberWithPrompt]; }],
@@ -1726,6 +1774,83 @@ - (void)signInFacebookAndRetrieveData {
   [self signinWithProvider:[AuthProviders facebook] retrieveData:YES];
 }
 
+- (void)logInWithSystemGameCenter {
+  GKLocalPlayer *localPlayer = [GKLocalPlayer localPlayer];
+  localPlayer.authenticateHandler = ^(UIViewController * _Nullable viewController,
+                                      NSError * _Nullable error) {
+    if (error) {
+      [self showTypicalUIForUserUpdateResultsWithTitle:@"Game Center Error" error:error];
+    } else if (viewController != nil) {
+      [self presentViewController:viewController animated:YES completion:nil];
+    }
+  };
+}
+
+- (void)signInWithGameCenter {
+  [FIRGameCenterAuthProvider getCredentialWithCompletion:
+   ^(FIRAuthCredential * _Nullable credential, NSError * _Nullable error) {
+     if (error) {
+       [self showTypicalUIForUserUpdateResultsWithTitle:@"Game Center Error" error:error];
+     } else {
+       [[AppManager auth] signInAndRetrieveDataWithCredential:credential
+                                                   completion:^(FIRAuthDataResult * _Nullable result,
+                                                                NSError * _Nullable error) {
+         [self hideSpinner:^{
+           if (error) {
+             [self logFailure:@"Sign in with Game Center failed" error:error];
+           } else {
+             [self logSuccess:@"Sign in with Game Center succeeded."];
+           }
+           [self showTypicalUIForUserUpdateResultsWithTitle:@"Sign In Error" error:error];
+         }];
+       }];
+     }
+   }];
+}
+
+- (void)linkWithGameCenter {
+  [FIRGameCenterAuthProvider getCredentialWithCompletion:
+   ^(FIRAuthCredential * _Nullable credential, NSError * _Nullable error) {
+     if (error) {
+       [self showTypicalUIForUserUpdateResultsWithTitle:@"Game Center Error" error:error];
+     } else {
+       [[self user] linkAndRetrieveDataWithCredential:credential
+                                           completion:^(FIRAuthDataResult * _Nullable result,
+                                                        NSError * _Nullable error) {
+                                             [self hideSpinner:^{
+                                               if (error) {
+                                                 [self logFailure:@"Link with Game Center failed" error:error];
+                                               } else {
+                                                 [self logSuccess:@"Link with Game Center succeeded."];
+                                               }
+                                               [self showTypicalUIForUserUpdateResultsWithTitle:@"Link Error" error:error];
+                                             }];
+                                           }];
+     }
+   }];
+}
+
+- (void)reauthenticateWithGameCenter {
+  [FIRGameCenterAuthProvider getCredentialWithCompletion:
+   ^(FIRAuthCredential * _Nullable credential, NSError * _Nullable error) {
+     if (error) {
+       [self showTypicalUIForUserUpdateResultsWithTitle:@"Game Center Error" error:error];
+     } else {
+       [[self user] reauthenticateAndRetrieveDataWithCredential:credential
+                                                     completion:^(FIRAuthDataResult * _Nullable result,
+                                                                  NSError * _Nullable error) {
+                                                       [self hideSpinner:^{
+                                                         if (error) {
+                                                           [self logFailure:@"Reauthenticate with Game Center failed" error:error];
+                                                         } else {
+                                                           [self logSuccess:@"Reauthenticate with Game Center succeeded."];
+                                                         }
+                                                         [self showTypicalUIForUserUpdateResultsWithTitle:@"Reauthenticate Error" error:error];
+                                                       }];
+                                                     }];
+     }
+   }];
+}
 /** @fn signInEmailPassword
     @brief Invoked when "Sign in with Email/Password" row is pressed.
  */

Example/Auth/Tests/FIRGetOOBConfirmationCodeRequestTests.m

@@ -126,6 +126,16 @@
  */
 static NSString *const kCanHandleCodeInAppKey = @"canHandleCodeInApp";
 
+/** @var kDynamicLinkDomainKey
+    @brief The key for the "dynamic link domain" value in the request.
+ */
+static NSString *const kDynamicLinkDomainKey = @"dynamicLinkDomain";
+
+/** @var kDynamicLinkDomain
+    @brief Fake dynamic link domain for testing.
+ */
+static NSString *const kDynamicLinkDomain = @"test.page.link";
+
 /** @class FIRGetOOBConfirmationCodeRequestTests
     @brief Tests for @c FIRGetOOBConfirmationCodeRequest.
  */
@@ -194,6 +204,7 @@ - (void)testPasswordResetRequest {
                         [NSNumber numberWithBool:YES]);
   XCTAssertEqualObjects(_RPCIssuer.decodedRequest[kCanHandleCodeInAppKey],
                         [NSNumber numberWithBool:YES]);
+  XCTAssertEqualObjects(_RPCIssuer.decodedRequest[kDynamicLinkDomainKey], kDynamicLinkDomain);
 }
 
 /** @fn testSignInWithEmailLinkRequest
@@ -230,6 +241,7 @@ - (void)testSignInWithEmailLinkRequest {
                         [NSNumber numberWithBool:YES]);
   XCTAssertEqualObjects(_RPCIssuer.decodedRequest[kCanHandleCodeInAppKey],
                         [NSNumber numberWithBool:YES]);
+  XCTAssertEqualObjects(_RPCIssuer.decodedRequest[kDynamicLinkDomainKey], kDynamicLinkDomain);
 }
 
 
@@ -268,6 +280,7 @@ - (void)testEmailVerificationRequest {
                         [NSNumber numberWithBool:YES]);
   XCTAssertEqualObjects(_RPCIssuer.decodedRequest[kCanHandleCodeInAppKey],
                         [NSNumber numberWithBool:YES]);
+  XCTAssertEqualObjects(_RPCIssuer.decodedRequest[kDynamicLinkDomainKey], kDynamicLinkDomain);
 }
 
 #pragma mark - Helpers
@@ -284,6 +297,7 @@ - (FIRActionCodeSettings *)fakeActionCodeSettings {
                              minimumVersion:kAndroidMinimumVersion];
   actionCodeSettings.handleCodeInApp = YES;
   actionCodeSettings.URL = [NSURL URLWithString:kContinueURL];
+  actionCodeSettings.dynamicLinkDomain = kDynamicLinkDomain;
   return actionCodeSettings;
 }