Skip to content

Commit 241a9d0

Browse files
committed
PR Feedback
1 parent 6a65c5a commit 241a9d0

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

Example/Auth/Tests/FIRAuthTests.m

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2269,9 +2269,8 @@ - (void)mockSecureTokenResponseWithError:(nullable NSError *)error {
22692269
*/
22702270
- (void)enableAutoTokenRefresh {
22712271
XCTestExpectation *expectation = [self expectationWithDescription:@"autoTokenRefreshcallback"];
2272-
id<FIRAuthInterop> auth = (id<FIRAuthInterop>)[FIRAuth auth];
2273-
[auth getTokenForcingRefresh:NO withCallback:^(NSString *_Nullable token,
2274-
NSError *_Nullable error) {
2272+
[[FIRAuth auth] getTokenForcingRefresh:NO withCallback:^(NSString *_Nullable token,
2273+
NSError *_Nullable error) {
22752274
[expectation fulfill];
22762275
}];
22772276
[self waitForExpectationsWithTimeout:kExpectationTimeout handler:nil];

Firebase/Auth/Source/FIRAuth.m

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
#import <UIKit/UIKit.h>
2323
#endif
2424

25-
#import <FirebaseAuthInterop/FIRAuthInterop.h>
2625
#import <FirebaseCore/FIRAppAssociationRegistration.h>
2726
#import <FirebaseCore/FIRAppInternal.h>
2827
#import <FirebaseCore/FIRComponent.h>
@@ -226,9 +225,9 @@ + (FIRActionCodeOperation)actionCodeOperationForRequestType:(NSString *)requestT
226225
#pragma mark - FIRAuth
227226

228227
#if TARGET_OS_IOS
229-
@interface FIRAuth () <FIRAuthAppDelegateHandler, FIRAuthInterop, FIRComponentRegistrant, FIRCoreConfigurable, FIRComponentLifecycleMaintainer>
228+
@interface FIRAuth () <FIRAuthAppDelegateHandler, FIRComponentRegistrant, FIRCoreConfigurable, FIRComponentLifecycleMaintainer>
230229
#else
231-
@interface FIRAuth () <FIRAuthInterop, FIRComponentRegistrant, FIRCoreConfigurable, FIRComponentLifecycleMaintainer>
230+
@interface FIRAuth () <FIRComponentRegistrant, FIRCoreConfigurable, FIRComponentLifecycleMaintainer>
232231
#endif
233232

234233
/** @property firebaseAppId

Firebase/Auth/Source/FIRAuth_Internal.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818

1919
#import "FIRAuth.h"
2020

21+
#import <FirebaseAuthInterop/FIRAuthInterop.h>
22+
2123
@class FIRAuthRequestConfiguration;
2224

2325
#if TARGET_OS_IOS
@@ -29,7 +31,7 @@
2931

3032
NS_ASSUME_NONNULL_BEGIN
3133

32-
@interface FIRAuth ()
34+
@interface FIRAuth () <FIRAuthInterop>
3335

3436
/** @property requestConfiguration
3537
@brief The configuration object comprising of paramters needed to make a request to Firebase

0 commit comments

Comments
 (0)