Makes "logger/compat" more focused on compatibility. Fixes #697 #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenzlong
approved these changes
Jun 9, 2020
CHANGELOG.md
Outdated
|
|
||
| ```js | ||
| require('firebase-functions/logger/compat'); | ||
| ``` | ||
|
|
||
| In older runtimes, logger prints to the console, and no structured data is saved. | ||
| In new runtimes, requiring this will emit text logs with multi-line support and appropriate severity. |
There was a problem hiding this comment.
Some questions to clarify in the changelog:
- Will it do anything in older runtimes?
- Specify that "new runtimes" refer to > Node.js 10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the implementation of
logger/compatto be a simple straightforward "frontport" of Node 8 logging to newer runtimes. This should make it easier for folks migrating to Node 10 to use as a drop-in fix for logging while they migrate to theloggerpackage over the long-term.Driven by discussion in #697