Skip to content

Modernize integration test #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 13, 2022
Merged

Modernize integration test #1074

merged 14 commits into from
Apr 13, 2022

Conversation

taeold
Copy link
Contributor

@taeold taeold commented Apr 12, 2022 •
edited
Loading

Small touchups to the existing integration test:

  1. Use node-fetch to simplify HTTP calls
  2. Group v1 triggers (in prep for running v2 trigger tests)
  3. Replace use of console.log to functions.logger.info
  4. Get rid of node10 as test target

@taeold taeold marked this pull request as ready for review April 12, 2022 07:46
@taeold taeold requested review from inlined and colerogers April 12, 2022 07:49
inlined
inlined approved these changes Apr 13, 2022
View reviewed changes
@taeold taeold merged commit 5f8770f into master Apr 13, 2022
@taeold taeold deleted the dl-integration-tests-v2 branch April 13, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inlined inlined inlined approved these changes

@colerogers colerogers Awaiting requested review from colerogers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taeold @inlined