Skip to content

refactor: code improvements #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: code improvements #264

wants to merge 2 commits into from

Conversation

CorieW
Copy link
Member

@CorieW CorieW commented May 12, 2025

  • Remove some unused imports
  • Stucture code consistently
  • Types go in own files

@CorieW CorieW force-pushed the @invertase/code-adjustments branch 2 times, most recently from bc21db5 to 1205233 Compare May 12, 2025 16:07
@CorieW CorieW requested a review from cabljac May 12, 2025 16:30
@cabljac cabljac moved this to Review Requested [PR] in [Cloud] Extensions + Functions May 19, 2025
cabljac
cabljac reviewed May 19, 2025
View reviewed changes
Copy link
Contributor

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm not approving for merge yet though, should we be careful about conflicts with any hanging PRs?

@CorieW CorieW force-pushed the @invertase/code-adjustments branch from 9993db0 to 5cef653 Compare May 19, 2025 15:13
@CorieW CorieW force-pushed the @invertase/code-adjustments branch from 5cef653 to a39719b Compare May 20, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cabljac cabljac cabljac left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CorieW @cabljac