-
Notifications
You must be signed in to change notification settings - Fork 124
Add an API flag to restore_secrets script #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Integration test with FLAKINESS (succeeded after retry)Requested by @DellaBitta on commit 5c3d695
Add flaky tests to go/fpl-cpp-flake-tracker |
scripts/gha/restore_secrets.py
Outdated
@@ -51,6 +53,7 @@ | |||
flags.DEFINE_string("passphrase_file", None, | |||
"Path to file with passphrase. Use \"-\" (without quotes) for stdin.") | |||
flags.DEFINE_string("artifact", None, "Artifact Path, google-services.json will be placed here.") | |||
flags.DEFINE_string("api", None, "Retrieve secret for the particular SDK only.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. And what about make it a list of api?
flags.DEFINE_list("apis", None, "Retrieve secret for the particular SDKs only.")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a usecase for this? Generally we're only working on one API/SDK at a time, or all at the same time in the case of CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. When someone tries to build only the failed testapps locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! PTAL!
Description
Whenever I do local development I run restore_secrets, which updates all of the Google Services data for all of the products. This pollutes my local branch since normally I'm only working on one product.
This change adds an optional
api
flag so that you can checkout the secrets for only one product at a time.Testing
Type of Change
Place an
x
the applicable box: