Skip to content

Add an API flag to restore_secrets script #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2022

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Jun 14, 2022

Description

Provide details of the change, and generalize the change in the PR title above.

Whenever I do local development I run restore_secrets, which updates all of the Google Services data for all of the products. This pollutes my local branch since normally I'm only working on one product.

This change adds an optional api flag so that you can checkout the secrets for only one product at a time.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@DellaBitta DellaBitta added tests-requested: quick Trigger a quick set of integration tests. skip-release-notes Skip release notes check labels Jun 14, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 14, 2022
@github-actions
Copy link

github-actions bot commented Jun 14, 2022

Integration test with FLAKINESS (succeeded after retry)

Requested by @DellaBitta on commit 5c3d695
Last updated: Fri Jun 17 13:14 PDT 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  TransactionTest.TestGetNonexistentDocumentThenCreate

Add flaky tests to go/fpl-cpp-flake-tracker

@DellaBitta DellaBitta marked this pull request as ready for review June 14, 2022 16:46
@DellaBitta DellaBitta requested a review from sunmou99 June 14, 2022 16:47
@@ -51,6 +53,7 @@
flags.DEFINE_string("passphrase_file", None,
"Path to file with passphrase. Use \"-\" (without quotes) for stdin.")
flags.DEFINE_string("artifact", None, "Artifact Path, google-services.json will be placed here.")
flags.DEFINE_string("api", None, "Retrieve secret for the particular SDK only.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. And what about make it a list of api?
flags.DEFINE_list("apis", None, "Retrieve secret for the particular SDKs only.")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a usecase for this? Generally we're only working on one API/SDK at a time, or all at the same time in the case of CI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. When someone tries to build only the failed testapps locally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! PTAL!

@DellaBitta DellaBitta requested a review from sunmou99 June 14, 2022 17:07
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 14, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 14, 2022
@DellaBitta DellaBitta requested a review from sunmou99 June 15, 2022 13:48
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Jun 15, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels Jun 15, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 15, 2022
@sunmou99 sunmou99 removed the tests: failed This PR's integration tests failed. label Jun 15, 2022
@github-actions github-actions bot added tests: failed This PR's integration tests failed. tests: succeeded This PR's integration tests succeeded. labels Jun 16, 2022
@DellaBitta DellaBitta removed the tests: failed This PR's integration tests failed. label Jun 17, 2022
@DellaBitta DellaBitta merged commit 5c3d695 into main Jun 17, 2022
@DellaBitta DellaBitta deleted the feature/api_restore_secrets branch June 17, 2022 17:27
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels Jun 17, 2022
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 17, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 17, 2022
@firebase firebase locked and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants