Run setup-java for Firestore emulator in GitHub Actions #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dconeybe
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
✅ Integration test succeeded!Requested by @dconeybe on commit 5c42ab6 |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
github-actions
bot
added
the
tests: succeeded
AlmostMatt
reviewed
May 30, 2022
AlmostMatt
approved these changes
May 30, 2022
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a problem where the Firestore integration tests were flakily failing in GitHub Actions runners due to the Firestore emulator failing to start.
If the GitHub Actions runner selected for integration testing had JDK 8 installed then the Firestore emulator would fail to start because recent releases of the Firestore emulator require JDK 11 or newer. This would cause the tests that attempt to communicate with the Firestore emulator to understandably fail.
The fix is to explicitly install JDK 11 (or newer) on GitHub Actions runners using the
setup-javaaction, instead of relying on the java version that happened to be installed on the runner.Googlers can see b/233751585 for details.