Skip to content

Update GHA CI Java Version #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2022
Merged

Update GHA CI Java Version #963

merged 4 commits into from
May 20, 2022

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented May 20, 2022

Description

Provide details of the change, and generalize the change in the PR title above.

The Firebase CLI tools require a java version 11+. The default GHA runner Java version did not meet this standard.
This change adds an extra workflow step to install a JRE of v17.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Integration Test CI
Desktop CI


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@DellaBitta DellaBitta added the skip-release-notes Skip release notes check label May 20, 2022
Copy link
Contributor

@cynthiajoan cynthiajoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need this for android?

@DellaBitta
Copy link
Contributor Author

Do we also need this for android?

It seems not. And I would rather not add it for the sake of things considering it might interfere with Gradle.

@DellaBitta DellaBitta marked this pull request as ready for review May 20, 2022 20:10
@DellaBitta DellaBitta enabled auto-merge (squash) May 20, 2022 20:13
@DellaBitta DellaBitta merged commit 0576371 into main May 20, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label May 20, 2022
@github-actions
Copy link

github-actions bot commented May 20, 2022

❌  Integration test FAILED

Requested by @DellaBitta on commit 0576371
Last updated: Fri May 20 17:50 PDT 2022
View integration test log & download artifacts

Failures Configs
auth [TEST] [FAILURE] [iOS] [macos] [1/2 ios_device: simulator_target]
(6 failed tests)  FirebaseAuthTest.TestCreateUserWithExistingEmailFails
  FirebaseAuthTest.TestEmailAndPasswordSignin
  FirebaseAuthTest.TestLinkAnonymousUserWithEmailCredential
  FirebaseAuthTest.TestSendPasswordResetEmail
  FirebaseAuthTest.TestSignInWithBadPasswordFails
  FirebaseAuthTest.TestUpdateEmailAndPassword
firestore
(4 items)[TEST] [ERROR] [Android] [All 2 os] [emulator_target]
[TEST] [ERROR] [iOS] [macos] [1/2 ios_device: simulator_target]
[TEST] [ERROR] [tvOS] [macos] [tvos_simulator]
[TEST] [FLAKINESS] [Android] [1/2 os: windows] [android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 20, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 21, 2022
@DellaBitta DellaBitta deleted the bugfix/update_ci_java branch May 24, 2022 17:12
@firebase firebase locked and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants