Skip to content

Mark the AdMob SDK as deprecated #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 23, 2022
Merged

Mark the AdMob SDK as deprecated #954

merged 9 commits into from
Jun 23, 2022

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented May 12, 2022 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

  • Mark AdMob SDK as deprecated.
  • Merge to main upon approval of feature/admob_2021 PR.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@DellaBitta DellaBitta requested a review from jonsimantov May 12, 2022 15:42
@DellaBitta DellaBitta marked this pull request as ready for review May 12, 2022 15:42
@DellaBitta DellaBitta changed the title Feature/deprecate admob Mark the AdMob SDK as deprecated May 12, 2022
@jonsimantov
Copy link
Contributor

This doesn't go in the admob_2021 branch?

@DellaBitta
Copy link
Contributor Author

We discussed at the weekly and resolved on having it go directly into the main branch as to not clutter up the feature branch.

@DellaBitta
Copy link
Contributor Author

But I can point it to the feature branch if you'd like.

jonsimantov
jonsimantov reviewed May 12, 2022
View reviewed changes
@jonsimantov jonsimantov self-requested a review May 13, 2022 00:11
@DellaBitta DellaBitta merged commit 25c0f6a into main Jun 23, 2022
@DellaBitta DellaBitta deleted the feature/deprecate_admob branch June 23, 2022 01:20
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jun 23, 2022
@github-actions
Copy link

github-actions bot commented Jun 23, 2022 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @DellaBitta on commit 25c0f6a
Last updated: Thu Jun 23 05:34 PDT 2022
View integration test log & download artifacts

Failures Configs
admob [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT
firestore [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 23, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 23, 2022
@firebase firebase locked and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonsimantov jonsimantov jonsimantov approved these changes

Assignees
No one assigned
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DellaBitta @jonsimantov