Add stdin option to restore_secrets for secure passphrase entry. #943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nner. This allows us to avoid passing in a passphrase on the command line, which can be insecure on a shared machine.
cynthiajoan
approved these changes
May 9, 2022
github-actions
bot
added
the
tests: in-progress
⏳ Integration test in progress...Requested by @jonsimantov on commit fd6c5c6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add stdin option to restore_secrets for secure passphrase entry. (Standard POSIX custom is for the filename "-" to refer to standard input.)
This allows us to avoid passing in a passphrase on the command line, which can be insecure on a multi-user machine (which a self-hosted runner could be).
Testing
Tested in #931.
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.