(Desktop) Firestore C++ Core from TIP by default #855
Conversation
wu-hui
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
✅ Integration test succeeded!Requested by @wu-hui on commit dcb0b3b |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
wu-hui
added
skip-release-notes
wu-hui
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
cmake/external/firestore.cmake
Outdated
|
|
||
| if(NOT FIRESTORE_DEP_SOURCE) | ||
| # Get from tip of the tree by default | ||
| GetTag("origin/master") |
There was a problem hiding this comment.
I would really rather not get from the tip of the tree by default - this could allow our build to break, as the build tree will get out of sync with our iOS dependencies. Having the option to get from HEAD is a good idea though, just not the default.
There was a problem hiding this comment.
It certainly can break CPP because we did a commit to iOS, but IMHO this is better than having to discover this by the time we start preparing for a release. We want to catch breakages like this as earlier as possible, when the person who make the commit still have good context.
Ideally, we should be able to run the tests as part of iOS PR CI, which stops the PR from committing if it breaks. Right now the long build time of CPP is not helping with this..
There was a problem hiding this comment.
Right now, the iOS dependency version updates all at once via a workflow (example: #845). This allows us to determine at a glance (if the integration tests succeed) that the new version works. If we allow Firestore to update its version out-of-band with that, anyone's random PR could have tests fail due to the iOS SDK changing out from under them. I don't believe that is an acceptable situation.
There was a problem hiding this comment.
As discussed offline, the default behavior now remains unchanged.
firebase-workflow-trigger
bot
removed
the
tests: in-progress
wu-hui
added
tests-requested: quick
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
cmake/external/firestore.cmake
Outdated
| GetTag("origin/master") | ||
| else() | ||
| if(FIRESTORE_DEP_SOURCE STREQUAL "RELEASED") | ||
| GetReleasedDep("CocoaPods-8.12.1") |
There was a problem hiding this comment.
@jonsimantov What about reuse "Update Android and iOS dependencies" workflow, and update the version here automatically?
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
No description provided.