Skip to content

Enable Firestore Emulator only when needed #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 24, 2022
Merged

Enable Firestore Emulator only when needed #852

merged 4 commits into from
Feb 24, 2022

Conversation

sunmou99
Copy link
Contributor

@sunmou99 sunmou99 commented Feb 15, 2022 •
edited
Loading

Description

  1. Test timeout extend to 90 mins.
    https://github.com/firebase/firebase-cpp-sdk/runs/5091186528?check_suite_focus=true
    ^ process timed out
  2. Enable Firestore Emulator only when needed.
    https://github.com/firebase/firebase-cpp-sdk/runs/5092455184?check_suite_focus=true
    ^ SIGINT and seems like no tests ran

Testing

See comments.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Feb 15, 2022
@sunmou99 sunmou99 requested a review from AlmostMatt February 15, 2022 00:43
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Feb 15, 2022
@github-actions
Copy link

github-actions bot commented Feb 15, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @sunmou99 on commit 0e9836f
Last updated: Thu Feb 24 13:49 PST 2022
View integration test log & download artifacts

Failures Configs
missing_log [BUILD] [ERROR] [iOS] [macos]
[TEST] [ERROR] [iOS] [macos] [All 2 ios_device]
firestore [TEST] [ERROR] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
[TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
functions [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
messaging [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Feb 15, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 15, 2022
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Feb 15, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Feb 15, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 15, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels Feb 16, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 17, 2022
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Feb 17, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Feb 17, 2022
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Feb 17, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 17, 2022
@sunmou99 sunmou99 enabled auto-merge (squash) February 18, 2022 00:22
@sunmou99 sunmou99 added the skip-release-notes Skip release notes check label Feb 24, 2022
@sunmou99 sunmou99 merged commit 0e9836f into main Feb 24, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Feb 24, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 24, 2022
@firebase firebase locked and limited conversation to collaborators Mar 27, 2022
@sunmou99 sunmou99 deleted the bugfix/firestore-emulator branch March 30, 2022 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlmostMatt AlmostMatt AlmostMatt approved these changes

@wu-hui wu-hui Awaiting requested review from wu-hui

@jonsimantov jonsimantov Awaiting requested review from jonsimantov

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunmou99 @AlmostMatt