Skip to content

Disable logging during AddCallback, which initializes too early. #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2022
Merged

Disable logging during AddCallback, which initializes too early. #827

merged 1 commit into from
Jan 26, 2022

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Jan 26, 2022 •
edited
Loading

This causes logging to initialize when static constructors are running.
On Xcode 13, this causes a crash when Firebase App is initialized in
the wrong order.

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov
Disable logging during AddCallback, which initializes too early.
a55bbe8 
This causes logging to initialize when static constructors are running.
On Xcode 13, this causes a crash when Firebase App is initialized in
the wrong order.
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Jan 26, 2022
@jonsimantov jonsimantov requested a review from a-maurice January 26, 2022 02:07
@jonsimantov jonsimantov enabled auto-merge (squash) January 26, 2022 02:07
@jonsimantov jonsimantov merged commit cf20054 into main Jan 26, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jan 26, 2022
@github-actions
Copy link

github-actions bot commented Jan 26, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit cf20054
Last updated: Tue Jan 25 21:11 PST 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [ERROR] [Android] [1/3 os: macos] [1/2 android_device: android_target]
[TEST] [FAILURE] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  ServerTimestampTest.TestServerTimestampsUsesPreviousValueFromLocalMutation
[TEST] [FLAKINESS] [Android] [2/3 os: windows ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jan 26, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 26, 2022
jonsimantov added a commit that referenced this pull request Feb 7, 2022
@jonsimantov
Revert "Disable logging during AddCallback, which initializes too ear…
fe4dd23 
…ly. (#827)"

This reverts commit cf20054.

This PR should fix the issue in a more general way.
jonsimantov added a commit that referenced this pull request Feb 8, 2022
@jonsimantov
Don't call FIRConfiguration setLoggerLevel: before FIRApp exists. (#843)
3c16566 
* Don't call FIRConfiguration setLoggerLevel: before FIRApp exists.

Instead, cache the value, and call setLoggerLevel later, after the iOS FIRApp instance is created.

* Add release note for this fix.

* Revert "Disable logging during AddCallback, which initializes too early. (#827)"

This reverts commit cf20054.

This PR should fix the issue in a more general way.
@firebase firebase locked and limited conversation to collaborators Feb 26, 2022
@jonsimantov jonsimantov deleted the fix-app-callback-logging branch April 23, 2022 01:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-maurice a-maurice a-maurice approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @a-maurice