Skip to content

Fixed errant uWebSockets git patch path #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2021
Merged

Fixed errant uWebSockets git patch path #521

merged 1 commit into from
Jul 10, 2021

Conversation

DellaBitta
Copy link
Contributor

renamed scripts/git/patches/uWebsockets to scripts/git/patches/uWebSockets. Note the S in uWebSockets.

@google-cla google-cla bot added the cla: yes label Jul 9, 2021
@DellaBitta DellaBitta requested a review from jonsimantov July 9, 2021 19:49
jonsimantov
jonsimantov approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@jonsimantov jonsimantov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, before merging to main, can you pull/merge this commit on your Mac and make sure git doesn't freak out?

@DellaBitta
Copy link
Contributor Author

Just to be sure, before merging to main, can you pull/merge this commit on your Mac and make sure git doesn't freak out?

Yep, it renames it properly. Good thought!

@DellaBitta DellaBitta merged commit 8ad99ec into main Jul 10, 2021
@DellaBitta DellaBitta deleted the fix/uWebSockets_path branch July 10, 2021 16:28
@github-actions
Copy link

github-actions bot commented Jul 10, 2021 •
edited
Loading

✅  Integration test succeeded!

Requested by @DellaBitta on commit 8ad99ec
Last updated: Sat Jul 10 17:03 PDT 2021
View integration test log & download artifacts

@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. labels Jul 10, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 11, 2021
@firebase firebase locked and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonsimantov jonsimantov jonsimantov approved these changes

Assignees
No one assigned
Labels
cla: yes tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DellaBitta @jonsimantov