Standardize header guards #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsimantov
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
❌ Integration test FAILEDRequested by @jonsimantov on commit 7843318
|
firebase-workflow-trigger
bot
removed
the
tests: in-progress
jonsimantov
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
jonsimantov
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
DellaBitta
approved these changes
Jul 8, 2021
jonsimantov
removed
the
tests: in-progress
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
jonsimantov
commented
Jul 12, 2021
| #ifndef FIREBASE_APP_CLIENT_CPP_SRC_INCLUDE_FIREBASE_APP_H_ | ||
| #define FIREBASE_APP_CLIENT_CPP_SRC_INCLUDE_FIREBASE_APP_H_ | ||
| #ifndef FIREBASE_APP_SRC_INCLUDE_FIREBASE_APP_H_ | ||
| #define FIREBASE_APP_SRC_INCLUDE_FIREBASE_APP_H_ | ||
|
|
There was a problem hiding this comment.
📝 Documentation issue: warning: argument 'confirg' of command @param is not found in the argument list of firebase::AppOptions::LoadFromJsonConfig(const char *config, AppOptions *options=nullptr)
| #ifndef FIREBASE_APP_CLIENT_CPP_SRC_INCLUDE_FIREBASE_APP_H_ | ||
| #define FIREBASE_APP_CLIENT_CPP_SRC_INCLUDE_FIREBASE_APP_H_ | ||
| #ifndef FIREBASE_APP_SRC_INCLUDE_FIREBASE_APP_H_ | ||
| #define FIREBASE_APP_SRC_INCLUDE_FIREBASE_APP_H_ | ||
|
|
||
| #include "firebase/internal/platform.h" | ||
|
|
There was a problem hiding this comment.
📝 Documentation issue: [8 lines down] warning: The following parameter of firebase::AppOptions::LoadFromJsonConfig(const char *config, AppOptions *options=nullptr) is not documented:
parameter 'config'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize header guards, and turn on lint warnings for bad header guard names and line length, which were previously disabled. Includes a small fix to replace " with " in the lint output, for HTML compatibility.
This also turns off the "include subdirectory" and "whitespace/indent" lint warnings as they are extraneous.