Update Auth ReauthenticateAndRetrieveData comments #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tests: in-progress
✅ Integration test succeeded!Requested by @DellaBitta on commit b1a2ce1 |
jonsimantov
pushed a commit
that referenced
this pull request
Jul 1, 2021
The behavior of ReauthenticateAndRetrieveData errors differ per platform. The preexisting comments documented the iOS behavior only, which was confusing for users of other platforms. This PR clarifies that errors on Android and Desktop platforms may cause the user to be signed out.
github-actions
bot
added
the
tests: succeeded
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of ReauthenticateAndRetrieveData errors differ per platform. The preexisting comments documented the iOS behavior only, which was confusing for users of other platforms.
This PR clarifies that errors on Android and Desktop platforms may cause the user to be signed out.