Skip to content

[RemoteConfig] Fix the fetch interval bug #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2021
Merged

[RemoteConfig] Fix the fetch interval bug #473

merged 2 commits into from
Jun 17, 2021

Conversation

cynthiajoan
Copy link
Contributor

To address issue firebase/quickstart-unity#1067, fix a few bugs in remote config cpp sdk desktop.

  1. Respect the ConfigSettings.minimum_fetch_interval_in_milliseconds in both FetchAndActivate() and Fetch()
  2. Allow ConfigSettings.minimum_fetch_interval_in_milliseconds value to be 0 and applied as valid fetch interval.
  3. Add integration test to verify.

@cynthiajoan cynthiajoan requested a review from jonsimantov June 16, 2021 05:39
@google-cla google-cla bot added the cla: yes label Jun 16, 2021
@cynthiajoan cynthiajoan merged commit 6b6729b into main Jun 17, 2021
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jun 17, 2021
@github-actions
Copy link

github-actions bot commented Jun 17, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @cynthiajoan on commit 6b6729b
Last updated: Thu Jun 17 11:48 PDT 2021
View integration test log & download artifacts

Failures Configs
messaging [TEST] [ERROR] [Android] [ubuntu] [android_latest]
remote_config [TEST] [FAILURE] [iOS] [macos] [ios_target]
(1 failed tests)  TestFetchInterval

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jun 17, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 17, 2021
@firebase firebase locked and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonsimantov jonsimantov jonsimantov approved these changes

Assignees
No one assigned
Labels
cla: yes tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cynthiajoan @jonsimantov