Add changelog entry for firestore::LoadBundle() #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var-const
suggested changes
Jun 15, 2021
release_build_files/readme.md
Outdated
| @@ -587,6 +587,9 @@ code. | |||
| with version 8.x of the Firebase iOS SDK. | |||
| - General (iOS): A Database URL is no longer required to be present in | |||
| GoogleService-Info.plist when not using the Real Time Database. | |||
| - Firestore: Added `Firestore::LoadBundle` to enable loading Firestore Data | |||
| Bundles to the SDK cache. `Firestore::NamedQuery` will be availabe in next | |||
There was a problem hiding this comment.
Nit: s/availabe/available/.
release_build_files/readme.md
Outdated
| @@ -587,6 +587,9 @@ code. | |||
| with version 8.x of the Firebase iOS SDK. | |||
| - General (iOS): A Database URL is no longer required to be present in | |||
| GoogleService-Info.plist when not using the Real Time Database. | |||
| - Firestore: Added `Firestore::LoadBundle` to enable loading Firestore Data | |||
| Bundles to the SDK cache. `Firestore::NamedQuery` will be availabe in next | |||
There was a problem hiding this comment.
Nit: add the (in the next release).
There was a problem hiding this comment.
On a second thought, how about a future release, just in case we run into any trouble?
release_build_files/readme.md
Outdated
| @@ -587,6 +587,9 @@ code. | |||
| with version 8.x of the Firebase iOS SDK. | |||
| - General (iOS): A Database URL is no longer required to be present in | |||
| GoogleService-Info.plist when not using the Real Time Database. | |||
| - Firestore: Added `Firestore::LoadBundle` to enable loading Firestore Data | |||
| Bundles to the SDK cache. `Firestore::NamedQuery` will be availabe in next | |||
There was a problem hiding this comment.
Hmm, I think it should be s/to/into/ (i.e., loading... into the cache). @jonsimantov Jon, which one looks better to you?
There was a problem hiding this comment.
into is better, IMO.
wu-hui
force-pushed
the
wuandy/LoadBundleChangeLog
branch
from
a363854 to
9aa4725
Compare
var-const
approved these changes
Jun 15, 2021
|
@wu-hui Approved, but please check with @jonsimantov Jon that these notes should be under the |
jonsimantov
approved these changes
Jun 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.